This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Pull actual data from the server instead of directly return in benchmark #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the benchmark runner did not pull any actual data from the server. Instead, it directly terminates the channel after getting the receiver. Running the previous code on
ParpulseStorageClientImplwill give out the following error:This PR fixes the problem. It also takes into account the time that the client pulls ALL data from the server. The
client_durationis now calculated as the total time from the client issuing the request till the client gets ALL data from the server.