Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Commit

Permalink
Cleanup (#11)
Browse files Browse the repository at this point in the history
  • Loading branch information
SimranMakhija7 authored May 2, 2024
1 parent fd5de3c commit 2b1bdf2
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 143 deletions.
4 changes: 2 additions & 2 deletions design_doc.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ We choose RocksDB as the database in the catalog to store metadata. It is a fast

## Design Rationale

An explanation of why you chose the given design. Your justification should discuss issues related to (1) correctness, (2) performance, (3) engineering complexity/maintainability, and (4) testing. It should also include a brief discussion of the other implementations that you considered and why they were deemed inferior.
Most design decisions were made with the assumption that we do not have any schema updates and writes are infrequent with bulk data

#### Database
Expand All @@ -42,7 +41,6 @@ We contemplated two embedded database candidates for catalog service: SQLite and
1. Better concurrency control: SQLite locks the entire database when dealing with concurrency writing, whereas RocksDB supports snapshots.
2. Flexibility: RocksDB provides more configuration options.
3. Scalability: RocksDB stores data in different partitions, whereas SQLite stores data in one single file, which isn’t ideal for scalability.
4. Storage: RocksDB uses key-value storage, which is good for intensive write operations. In short, RocksDB would provide better performance and concurrency control when we deal with write-intensive workloads.

#### Why a key-value store?

Expand Down Expand Up @@ -142,13 +140,15 @@ Duration [total, attack, wait] 9.9895398s, 9.9890283s, 511.5µs
Latencies [mean, 50, 95, 99, max] 1.883553ms, 1.191091ms, 5.006752ms, 8.196381ms, 43.6933ms
```
![](./test_results/windows/list_namespace.png)

#### List Tables API
```
Requests [total, rate, throughput] 9992, 999.50, 999.50
Duration [total, attack, wait] 9.9970348s, 9.9970348s, 0s
Latencies [mean, 50, 95, 99, max] 971.232µs, 973.659µs, 1.978657ms, 3.292131ms, 45.7625ms
```
![](./test_results/windows/list_table.png)

#### Random Testing
```
Requests [total, rate, throughput] 59995, 1000.02, 1000.02
Expand Down
137 changes: 0 additions & 137 deletions src/dto/errors.rs

This file was deleted.

1 change: 0 additions & 1 deletion src/dto/mod.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
pub mod column_data;
pub mod errors;
pub mod namespace_data;
pub mod rename_request;
pub mod set_namespace_properties_req;
Expand Down
3 changes: 0 additions & 3 deletions src/handlers/namespace_handler.rs
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,6 @@ mod tests {
use tempfile::tempdir;
#[tokio::test]
async fn test_namespace_endpoints() {
let dir = tempdir().unwrap();
let db = Database::open(dir.path()).unwrap();
let db = Arc::new(Mutex::new(db));
let repo = Arc::new(NamespaceRepository::new(Arc::new(Mutex::new(
Database::open(tempdir().unwrap().path()).unwrap(),
))));
Expand Down

0 comments on commit 2b1bdf2

Please sign in to comment.