Internal Query Execution Status (Issue #1555) #1561

17zhangw · 2021-04-22T08:41:23Z

Description

PR resolves issue #1555. The PR augments TaskDDL with a future that can be used by the caller to identify whether or not the DDL query has succeeded or failed (along with obtaining an error message associated with the failure). PR also performs the following:

util::QueryExecUtil now tracks a "most-recent" error that can be obtained.
util::QueryExecUtil::ExecuteQuery returns false now if the transaction must abort due to execution

noisepage-checks · 2021-04-22T13:12:31Z

Minor Decrease in Performance

Be warned: this PR may have decreased the throughput of the system slightly.

tps (%change)	benchmark_type	wal_device	details
-1.69%	tpcc	RAM disk	Details master tps=22530.23, commit tps=22150.08, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=RAM disk, max_connection_threads=32
-3.06%	tpcc	None	Details master tps=29053.25, commit tps=28163.86, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=None, max_connection_threads=32
4.0%	tpcc	HDD	Details master tps=21306.08, commit tps=22158.38, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=HDD, max_connection_threads=32
-3.72%	tatp	RAM disk	Details master tps=6471.86, commit tps=6230.82, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=RAM disk, max_connection_threads=32
0.36%	tatp	None	Details master tps=7441.97, commit tps=7468.9, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=None, max_connection_threads=32
7.33%	tatp	HDD	Details master tps=6369.09, commit tps=6836.13, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=HDD, max_connection_threads=32

codecov · 2021-04-22T13:12:32Z

Codecov Report

Merging #1561 (474f5f4) into master (63eafbd) will increase coverage by 0.01%.
The diff coverage is 76.31%.

@@            Coverage Diff             @@
##           master    #1561      +/-   ##
==========================================
+ Coverage   81.97%   81.99%   +0.01%     
==========================================
  Files         735      736       +1     
  Lines       51698    51726      +28     
==========================================
+ Hits        42379    42412      +33     
+ Misses       9319     9314       -5

Impacted Files	Coverage Δ
src/self_driving/planning/pilot.cpp	`0.00% <0.00%> (ø)`
src/self_driving/planning/pilot_util.cpp	`0.00% <0.00%> (ø)`
src/task/task.cpp	`96.87% <85.71%> (-3.13%)`	⬇️
src/util/query_exec_util.cpp	`86.95% <95.23%> (+1.04%)`	⬆️
src/include/task/task.h	`92.00% <100.00%> (+0.33%)`	⬆️
src/include/util/query_exec_util.h	`100.00% <100.00%> (ø)`
...xecution/compiler/operator/operator_translator.cpp	`61.86% <0.00%> (-0.85%)`	⬇️
src/include/storage/index/bplustree.h	`89.60% <0.00%> (-0.12%)`	⬇️
src/include/common/future.h	`100.00% <0.00%> (ø)`
src/network/connection_handle.cpp	`64.06% <0.00%> (ø)`
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63eafbd...474f5f4. Read the comment docs.

noisepage-checks · 2021-04-22T22:02:38Z

Minor Decrease in Performance

Be warned: this PR may have decreased the throughput of the system slightly.

tps (%change)	benchmark_type	wal_device	details
1.52%	tpcc	RAM disk	Details master tps=22530.23, commit tps=22873.78, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=RAM disk, max_connection_threads=32
-1.47%	tpcc	None	Details master tps=29053.25, commit tps=28625.27, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=None, max_connection_threads=32
0.7%	tpcc	HDD	Details master tps=21306.08, commit tps=21455.63, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=HDD, max_connection_threads=32
9.16%	tatp	RAM disk	Details master tps=6471.86, commit tps=7064.76, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=RAM disk, max_connection_threads=32
1.14%	tatp	None	Details master tps=7441.97, commit tps=7526.89, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=None, max_connection_threads=32
8.93%	tatp	HDD	Details master tps=6369.09, commit tps=6937.64, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=HDD, max_connection_threads=32

linmagit

Looks great. Thanks, @17zhangw!

noisepage-checks · 2021-04-24T01:24:41Z

Performance Boost!

Nice job! This PR has increased the throughput of the system.

Could not find any performance results to compare for this commit.

src/include/util/query_exec_util.h

noisepage-checks · 2021-04-24T20:46:34Z

Performance Boost!

Nice job! This PR has increased the throughput of the system.

Could not find any performance results to compare for this commit.

…ddl_catch

noisepage-checks · 2021-04-27T23:28:02Z

Minor Decrease in Performance

Be warned: this PR may have decreased the throughput of the system slightly.

tps (%change)	benchmark_type	wal_device	details
-3.11%	tpcc	RAM disk	Details master tps=22836.4, commit tps=22126.36, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=RAM disk, max_connection_threads=32
-0.99%	tpcc	None	Details master tps=29391.44, commit tps=29099.96, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=None, max_connection_threads=32
-0.57%	tpcc	HDD	Details master tps=21885.3, commit tps=21759.86, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=HDD, max_connection_threads=32
8.11%	tatp	RAM disk	Details master tps=6412.12, commit tps=6932.27, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=RAM disk, max_connection_threads=32
-3.06%	tatp	None	Details master tps=7634.94, commit tps=7401.12, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=None, max_connection_threads=32
6.05%	tatp	HDD	Details master tps=6482.1, commit tps=6874.11, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=HDD, max_connection_threads=32

noisepage-checks · 2021-04-28T07:15:33Z

Minor Decrease in Performance

Be warned: this PR may have decreased the throughput of the system slightly.

tps (%change)	benchmark_type	wal_device	details
-2.54%	tpcc	RAM disk	Details master tps=22836.4, commit tps=22255.87, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=RAM disk, max_connection_threads=32
-2.87%	tpcc	None	Details master tps=29391.44, commit tps=28548.44, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=None, max_connection_threads=32
-0.13%	tpcc	HDD	Details master tps=21885.3, commit tps=21856.47, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=HDD, max_connection_threads=32
9.3%	tatp	RAM disk	Details master tps=6412.12, commit tps=7008.26, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=RAM disk, max_connection_threads=32
-1.14%	tatp	None	Details master tps=7634.94, commit tps=7548.07, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=None, max_connection_threads=32
6.06%	tatp	HDD	Details master tps=6482.1, commit tps=6875.17, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=HDD, max_connection_threads=32

noisepage-checks · 2021-04-29T21:57:05Z

Minor Decrease in Performance

Be warned: this PR may have decreased the throughput of the system slightly.

tps (%change)	benchmark_type	wal_device	details
-0.03%	tpcc	RAM disk	Details master tps=22262.69, commit tps=22255.87, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=RAM disk, max_connection_threads=32
-2.34%	tpcc	None	Details master tps=29232.28, commit tps=28548.44, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=None, max_connection_threads=32
0.03%	tpcc	HDD	Details master tps=21850.76, commit tps=21856.47, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=HDD, max_connection_threads=32
6.5%	tatp	RAM disk	Details master tps=6580.67, commit tps=7008.26, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=RAM disk, max_connection_threads=32
1.69%	tatp	None	Details master tps=7422.79, commit tps=7548.07, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=None, max_connection_threads=32
7.78%	tatp	HDD	Details master tps=6378.92, commit tps=6875.17, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=HDD, max_connection_threads=32

noisepage-checks · 2021-04-30T23:24:36Z

Minor Decrease in Performance

Be warned: this PR may have decreased the throughput of the system slightly.

tps (%change)	benchmark_type	wal_device	details
-0.44%	tpcc	RAM disk	Details master tps=22481.16, commit tps=22383.35, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=RAM disk, max_connection_threads=32
1.66%	tpcc	None	Details master tps=29456.63, commit tps=29945.92, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=None, max_connection_threads=32
1.13%	tpcc	HDD	Details master tps=21486.66, commit tps=21729.79, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=HDD, max_connection_threads=32
6.05%	tatp	RAM disk	Details master tps=6552.52, commit tps=6948.87, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=RAM disk, max_connection_threads=32
-0.81%	tatp	None	Details master tps=7420.32, commit tps=7359.92, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=None, max_connection_threads=32
6.74%	tatp	HDD	Details master tps=6437.02, commit tps=6870.65, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=HDD, max_connection_threads=32

noisepage-checks · 2021-05-01T08:49:57Z

Minor Decrease in Performance

Be warned: this PR may have decreased the throughput of the system slightly.

tps (%change)	benchmark_type	wal_device	details
-0.44%	tpcc	RAM disk	Details master tps=22481.16, commit tps=22383.35, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=RAM disk, max_connection_threads=32
1.66%	tpcc	None	Details master tps=29456.63, commit tps=29945.92, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=None, max_connection_threads=32
-0.45%	tpcc	HDD	Details master tps=21828.82, commit tps=21729.79, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=HDD, max_connection_threads=32
6.05%	tatp	RAM disk	Details master tps=6552.52, commit tps=6948.87, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=RAM disk, max_connection_threads=32
-0.81%	tatp	None	Details master tps=7420.32, commit tps=7359.92, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=None, max_connection_threads=32
6.85%	tatp	HDD	Details master tps=6430.24, commit tps=6870.65, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=HDD, max_connection_threads=32

noisepage-checks · 2021-05-01T20:48:38Z

Minor Decrease in Performance

Be warned: this PR may have decreased the throughput of the system slightly.

tps (%change)	benchmark_type	wal_device	details
0.35%	tpcc	RAM disk	Details master tps=22305.86, commit tps=22383.35, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=RAM disk, max_connection_threads=32
1.91%	tpcc	None	Details master tps=29385.22, commit tps=29945.92, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=None, max_connection_threads=32
-0.45%	tpcc	HDD	Details master tps=21828.82, commit tps=21729.79, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=HDD, max_connection_threads=32
3.65%	tatp	RAM disk	Details master tps=6704.39, commit tps=6948.87, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=RAM disk, max_connection_threads=32
-0.13%	tatp	None	Details master tps=7369.54, commit tps=7359.92, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=None, max_connection_threads=32
6.85%	tatp	HDD	Details master tps=6430.24, commit tps=6870.65, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=HDD, max_connection_threads=32

noisepage-checks · 2021-05-03T07:03:08Z

Minor Decrease in Performance

Be warned: this PR may have decreased the throughput of the system slightly.

tps (%change)	benchmark_type	wal_device	details
3.28%	tpcc	RAM disk	Details master tps=22486.01, commit tps=23223.24, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=RAM disk, max_connection_threads=32
2.84%	tpcc	None	Details master tps=28899.18, commit tps=29719.93, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=None, max_connection_threads=32
-0.03%	tpcc	HDD	Details master tps=21536.43, commit tps=21528.9, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=HDD, max_connection_threads=32
7.11%	tatp	RAM disk	Details master tps=6504.65, commit tps=6966.94, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=RAM disk, max_connection_threads=32
0.12%	tatp	None	Details master tps=7494.53, commit tps=7503.86, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=None, max_connection_threads=32
3.97%	tatp	HDD	Details master tps=6537.43, commit tps=6797.11, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=HDD, max_connection_threads=32

Sync error message for DDL

3b0b110

17zhangw self-assigned this Apr 22, 2021

17zhangw added the ready-for-ci Indicate that this build should be run through CI. label Apr 22, 2021

Fix query_trace_logging_test compile

f04c08a

Merge branch 'master' into ddl_catch

da10440

17zhangw requested a review from linmagit April 22, 2021 22:35

17zhangw added the ready-for-review This PR passes all checks and is ready to be reviewed. Mark PRs with this. label Apr 22, 2021

Merge branch 'master' into ddl_catch

9385b66

linmagit approved these changes Apr 23, 2021

View reviewed changes

lmwnshn reviewed Apr 24, 2021

View reviewed changes

src/include/util/query_exec_util.h Show resolved Hide resolved

17zhangw added 7 commits April 27, 2021 14:40

Merge remote-tracking branch 'cmudb/master' into ddl_catch

c73b987

Reset error on any operation that can encounter an error

2cc0681

Merge branch 'ddl_catch' of https://github.com/17zhangw/terrier into …

daf5c63

…ddl_catch

Merge branch 'master' into ddl_catch

d99f617

format

e5b1edf

Merge branch 'ddl_catch' of https://github.com/17zhangw/terrier into …

54c9b74

…ddl_catch

check-lint

c838e61

Merge remote-tracking branch 'cmudb/master' into ddl_catch

8fda6d9

Merge branch 'master' into ddl_catch

8f9b609

Merge branch 'master' into ddl_catch

474f5f4

17zhangw added ready-to-merge This PR is ready to be merged. Mark PRs with this. and removed ready-for-review This PR passes all checks and is ready to be reviewed. Mark PRs with this. labels May 3, 2021

linmagit merged commit e8fd9b0 into cmu-db:master May 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Internal Query Execution Status (Issue #1555) #1561

Internal Query Execution Status (Issue #1555) #1561

17zhangw commented Apr 22, 2021

noisepage-checks bot commented Apr 22, 2021

codecov bot commented Apr 22, 2021 •

edited

Loading

noisepage-checks bot commented Apr 22, 2021

linmagit left a comment

noisepage-checks bot commented Apr 24, 2021

noisepage-checks bot commented Apr 24, 2021

noisepage-checks bot commented Apr 27, 2021

noisepage-checks bot commented Apr 28, 2021

noisepage-checks bot commented Apr 29, 2021

noisepage-checks bot commented Apr 30, 2021

noisepage-checks bot commented May 1, 2021

noisepage-checks bot commented May 1, 2021

noisepage-checks bot commented May 3, 2021

Internal Query Execution Status (Issue #1555) #1561

Internal Query Execution Status (Issue #1555) #1561

Conversation

17zhangw commented Apr 22, 2021

Description

noisepage-checks bot commented Apr 22, 2021

Minor Decrease in Performance

codecov bot commented Apr 22, 2021 • edited Loading

Codecov Report

noisepage-checks bot commented Apr 22, 2021

Minor Decrease in Performance

linmagit left a comment

Choose a reason for hiding this comment

noisepage-checks bot commented Apr 24, 2021

Performance Boost!

noisepage-checks bot commented Apr 24, 2021

Performance Boost!

noisepage-checks bot commented Apr 27, 2021

Minor Decrease in Performance

noisepage-checks bot commented Apr 28, 2021

Minor Decrease in Performance

noisepage-checks bot commented Apr 29, 2021

Minor Decrease in Performance

noisepage-checks bot commented Apr 30, 2021

Minor Decrease in Performance

noisepage-checks bot commented May 1, 2021

Minor Decrease in Performance

noisepage-checks bot commented May 1, 2021

Minor Decrease in Performance

noisepage-checks bot commented May 3, 2021

Minor Decrease in Performance

codecov bot commented Apr 22, 2021 •

edited

Loading