Skip to content

WIP Built some initial e2e datafusion infrastructure #33

WIP Built some initial e2e datafusion infrastructure

WIP Built some initial e2e datafusion infrastructure #33

GitHub Actions / clippy failed Jan 20, 2025 in 1s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (33)

infra/src/query_planner.rs|15 col 41| warning: use of deprecated type alias datafusion::execution::runtime_env::RuntimeConfig: please use RuntimeEnvBuilder instead
--> infra/src/query_planner.rs:15:41
|
15 | use datafusion::execution::runtime_env::RuntimeConfig;
| ^^^^^^^^^^^^^
|
= note: #[warn(deprecated)] on by default
infra/src/query_planner.rs|164 col 23| warning: use of deprecated type alias datafusion::execution::runtime_env::RuntimeConfig: please use RuntimeEnvBuilder instead
--> infra/src/query_planner.rs:164:23
|
164 | rn_config: Option,
| ^^^^^^^^^^^^^
infra/src/query_planner.rs|181 col 9| warning: use of deprecated type alias datafusion::execution::runtime_env::RuntimeConfig: please use RuntimeEnvBuilder instead
--> infra/src/query_planner.rs:181:9
|
181 | RuntimeConfig::new()
| ^^^^^^^^^^^^^
infra/src/query_planner.rs|79 col 28| warning: unused variable: verbose
--> infra/src/query_planner.rs:79:28
|
79 | let (mut explains, verbose, logical_plan) = match logical_plan {
| ^^^^^^^ help: if this is intentional, prefix it with an underscore: _verbose
|
= note: #[warn(unused_variables)] on by default
infra/src/query_planner.rs|85 col 17| warning: unused variable: ctx
--> infra/src/query_planner.rs:85:17
|
85 | let mut ctx = OptdPlanContext::new(session_state);
| ^^^ help: if this is intentional, prefix it with an underscore: _ctx
infra/src/query_planner.rs|94 col 17| warning: unused variable: optimizer
--> infra/src/query_planner.rs:94:17
|
94 | let mut optimizer = self.optimizer.lock().unwrap().take().unwrap();
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: _optimizer
infra/src/query_planner.rs|85 col 13| warning: variable does not need to be mutable
--> infra/src/query_planner.rs:85:13
|
85 | let mut ctx = OptdPlanContext::new(session_state);
| ----^^^
| |
| help: remove this mut
|
= note: #[warn(unused_mut)] on by default
infra/src/query_planner.rs|94 col 13| warning: variable does not need to be mutable
--> infra/src/query_planner.rs:94:13
|
94 | let mut optimizer = self.optimizer.lock().unwrap().take().unwrap();
| ----^^^^^^^^^
| |
| help: remove this mut
infra/src/query_planner.rs|27 col 5| warning: type query_planner::DatafusionOptimizer is more private than the item query_planner::OptdPlanContext::optimizer
--> infra/src/query_planner.rs:27:5
|
27 | pub optimizer: Option<&'a DatafusionOptimizer>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field query_planner::OptdPlanContext::optimizer is reachable at visibility pub(crate)
|
note: but type query_planner::DatafusionOptimizer is only usable at visibility pub(self)
--> infra/src/query_planner.rs:22:1
|
22 | struct DatafusionOptimizer {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: #[warn(private_interfaces)] on by default
infra/src/query_planner.rs|41 col 5| warning: type query_planner::DatafusionOptimizer is more private than the item query_planner::OptdQueryPlanner::optimizer
--> infra/src/query_planner.rs:41:5
|
41 | pub optimizer: Arc<Mutex<Option<Box>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field query_planner::OptdQueryPlanner::optimizer is reachable at visibility pub(crate)
|
note: but type query_planner::DatafusionOptimizer is only usable at visibility pub(self)
--> infra/src/query_planner.rs:22:1
|
22 | struct DatafusionOptimizer {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
infra/src/query_planner.rs|107 col 5| warning: type query_planner::DatafusionOptimizer is more private than the item query_planner::OptdQueryPlanner::new
--> infra/src/query_planner.rs:107:5
|
107 | pub fn new(optimizer: DatafusionOptimizer) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function query_planner::OptdQueryPlanner::new is reachable at visibility pub(crate)
|
note: but type query_planner::DatafusionOptimizer is only usable at visibility pub(self)
--> infra/src/query_planner.rs:22:1
|
22 | struct DatafusionOptimizer {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
infra/src/query_planner.rs|24 col 12| warning: fields tables, session_state, and optimizer are never read
--> infra/src/query_planner.rs:25:5
|
24 | pub struct OptdPlanContext<'a> {
| --------------- fields in this struct
25 | tables: HashMap<String, Arc>,
| ^^^^^^
26 | session_state: &'a SessionState,
| ^^^^^^^^^^^^^
27 | pub optimizer: Option<&'a DatafusionOptimizer>,
| ^^^^^^^^^
|
= note: #[warn(dead_code)] on by default
infra/src/query_planner.rs|44 col 1| warning: associated items enable_adaptive, disable_adaptive, and new are never used
--> infra/src/query_planner.rs:45:12
|
44 | impl OptdQueryPlanner {
| --------------------- associated items in this implementation
45 | pub fn enable_adaptive(&self) {
| ^^^^^^^^^^^^^^^
...
55 | pub fn disable_adaptive(&self) {
| ^^^^^^^^^^^^^^^^
...
107 | pub fn new(optimizer: DatafusionOptimizer) -> Self {
| ^^^
infra/src/query_planner.rs|135 col 6| warning: enum JoinOrder is never used
--> infra/src/query_planner.rs:135:6
|
135 | enum JoinOrder {
| ^^^^^^^^^
infra/src/query_planner.rs|155 col 12| warning: struct OptdDfContext is never constructed
--> infra/src/query_planner.rs:155:12
|
155 | pub struct OptdDfContext {
| ^^^^^^^^^^^^^
infra/src/query_planner.rs|162 col 14| warning: function create_df_context is never used
--> infra/src/query_planner.rs:162:14
|
162 | pub async fn create_df_context(
| ^^^^^^^^^^^^^^^^^
infra/src/main.rs|4 col 41| warning: use of deprecated type alias datafusion::execution::runtime_env::RuntimeConfig: please use RuntimeEnvBuilder instead
--> infra/src/main.rs:4:41
|
4 | use datafusion::execution::runtime_env::RuntimeConfig;
| ^^^^^^^^^^^^^
|
= note: #[warn(deprecated)] on by default
infra/src/main.rs|15 col 21| warning: use of deprecated type alias datafusion::execution::runtime_env::RuntimeConfig: please use RuntimeEnvBuilder instead
--> infra/src/main.rs:15:21
|
15 | let rt_config = RuntimeConfig::new();
| ^^^^^^^^^^^^^
infra/src/query_planner.rs|15 col 41| warning: use of deprecated type alias datafusion::execution::runtime_env::RuntimeConfig: please use RuntimeEnvBuilder instead
--> infra/src/query_planner.rs:15:41
|
15 | use datafusion::execution::runtime_env::RuntimeConfig;
| ^^^^^^^^^^^^^
infra/src/query_planner.rs|164 col 23| warning: use of deprecated type alias datafusion::execution::runtime_env::RuntimeConfig: please use RuntimeEnvBuilder instead
--> infra/src/query_planner.rs:164:23
|
164 | rn_config: Option,
| ^^^^^^^^^^^^^
infra/src/query_planner.rs|181 col 9| warning: use of deprecated type alias datafusion::execution::runtime_env::RuntimeConfig: please use RuntimeEnvBuilder instead
--> infra/src/query_planner.rs:181:9
|
181 | RuntimeConfig::new()
| ^^^^^^^^^^^^^
infra/src/query_planner.rs|79 col 28| warning: unused variable: verbose
--> infra/src/query_planner.rs:79:28
|
79 | let (mut explains, verbose, logical_plan) = match logical_plan {
| ^^^^^^^ help: if this is intentional, prefix it with an underscore: _verbose
|
= note: #[warn(unused_variables)] on by default
infra/src/query_planner.rs|85 col 17| warning: unused variable: ctx
--> infra/src/query_planner.rs:85:17
|
85 | let mut ctx = OptdPlanContext::new(session_state);
| ^^^ help: if this is intentional, prefix it with an underscore: _ctx
infra/src/query_planner.rs|94 col 17| warning: unused variable: optimizer
--> infra/src/query_planner.rs:94:17
|
94 | let mut optimizer = self.optimizer.lock().unwrap().take().unwrap();
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: _optimizer
infra/src/query_planner.rs|85 col 13| warning: variable does not need to be mutable
--> infra/src/query_planner.rs:85:13
|
85 | let mut ctx = OptdPlanContext::new(session_state);
| ----^^^
| |
| help: remove this mut
|
= note: #[warn(unused_mut)] on by default
infra/src/query_planner.rs|94 col 13| warning: variable does not need to be mutable
--> infra/src/query_planner.rs:94:13
|
94 | let mut optimizer = self.optimizer.lock().unwrap().take().unwrap();
| ----^^^^^^^^^
| |
| help: remove this mut
infra/src/query_planner.rs|27 col 5| warning: type query_planner::DatafusionOptimizer is more private than the item query_planner::OptdPlanContext::optimizer
--> infra/src/query_planner.rs:27:5
|
27 | pub optimizer: Option<&'a DatafusionOptimizer>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field query_planner::OptdPlanContext::optimizer is reachable at visibility pub(crate)
|
note: but type query_planner::DatafusionOptimizer is only usable at visibility pub(self)
--> infra/src/query_planner.rs:22:1
|
22 | struct DatafusionOptimizer {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: #[warn(private_interfaces)] on by default
infra/src/query_planner.rs|41 col 5| warning: type query_planner::DatafusionOptimizer is more private than the item query_planner::OptdQueryPlanner::optimizer
--> infra/src/query_planner.rs:41:5
|
41 | pub optimizer: Arc<Mutex<Option<Box>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field query_planner::OptdQueryPlanner::optimizer is reachable at visibility pub(crate)
|
note: but type query_planner::DatafusionOptimizer is only usable at visibility pub(self)
--> infra/src/query_planner.rs:22:1
|
22 | struct DatafusionOptimizer {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
infra/src/query_planner.rs|107 col 5| warning: type query_planner::DatafusionOptimizer is more private than the item query_planner::OptdQueryPlanner::new
--> infra/src/query_planner.rs:107:5
|
107 | pub fn new(optimizer: DatafusionOptimizer) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function query_planner::OptdQueryPlanner::new is reachable at visibility pub(crate)
|
note: but type query_planner::DatafusionOptimizer is only usable at visibility pub(self)
--> infra/src/query_planner.rs:22:1
|
22 | struct DatafusionOptimizer {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
infra/src/query_planner.rs|24 col 12| warning: fields tables, session_state, and optimizer are never read
--> infra/src/query_planner.rs:25:5
|
24 | pub struct OptdPlanContext<'a> {
| --------------- fields in this struct
25 | tables: HashMap<String, Arc>,
| ^^^^^^
26 | session_state: &'a SessionState,
| ^^^^^^^^^^^^^
27 | pub optimizer: Option<&'a DatafusionOptimizer>,
| ^^^^^^^^^
|
= note: #[warn(dead_code)] on by default
infra/src/query_planner.rs|44 col 1| warning: methods enable_adaptive and disable_adaptive are never used
--> infra/src/query_planner.rs:45:12
|
44 | impl OptdQueryPlanner {
| --------------------- methods in this implementation
45 | pub fn enable_adaptive(&self) {
| ^^^^^^^^^^^^^^^
...
55 | pub fn disable_adaptive(&self) {
| ^^^^^^^^^^^^^^^^
infra/src/query_planner.rs|135 col 6| warning: enum JoinOrder is never used
--> infra/src/query_planner.rs:135:6
|
135 | enum JoinOrder {
| ^^^^^^^^^
infra/src/query_planner.rs|155 col 12| warning: fields catalog and optimizer are never read
--> infra/src/query_planner.rs:157:9
|
155 | pub struct OptdDfContext {
| ------------- fields in this struct
156 | pub ctx: SessionContext,
157 | pub catalog: Arc,
| ^^^^^^^
158 | pub optimizer: Arc,
| ^^^^^^^^^

Filtered Findings (0)

Annotations

Check warning on line 15 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L15

warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
  --> infra/src/query_planner.rs:15:41
   |
15 | use datafusion::execution::runtime_env::RuntimeConfig;
   |                                         ^^^^^^^^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default
Raw output
infra/src/query_planner.rs:15:41:w:warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
  --> infra/src/query_planner.rs:15:41
   |
15 | use datafusion::execution::runtime_env::RuntimeConfig;
   |                                         ^^^^^^^^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default


__END__

Check warning on line 164 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L164

warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
   --> infra/src/query_planner.rs:164:23
    |
164 |     rn_config: Option<RuntimeConfig>,
    |                       ^^^^^^^^^^^^^
Raw output
infra/src/query_planner.rs:164:23:w:warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
   --> infra/src/query_planner.rs:164:23
    |
164 |     rn_config: Option<RuntimeConfig>,
    |                       ^^^^^^^^^^^^^


__END__

Check warning on line 181 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L181

warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
   --> infra/src/query_planner.rs:181:9
    |
181 |         RuntimeConfig::new()
    |         ^^^^^^^^^^^^^
Raw output
infra/src/query_planner.rs:181:9:w:warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
   --> infra/src/query_planner.rs:181:9
    |
181 |         RuntimeConfig::new()
    |         ^^^^^^^^^^^^^


__END__

Check warning on line 79 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L79

warning: unused variable: `verbose`
  --> infra/src/query_planner.rs:79:28
   |
79 |         let (mut explains, verbose, logical_plan) = match logical_plan {
   |                            ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_verbose`
   |
   = note: `#[warn(unused_variables)]` on by default
Raw output
infra/src/query_planner.rs:79:28:w:warning: unused variable: `verbose`
  --> infra/src/query_planner.rs:79:28
   |
79 |         let (mut explains, verbose, logical_plan) = match logical_plan {
   |                            ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_verbose`
   |
   = note: `#[warn(unused_variables)]` on by default


__END__

Check warning on line 85 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L85

warning: unused variable: `ctx`
  --> infra/src/query_planner.rs:85:17
   |
85 |         let mut ctx = OptdPlanContext::new(session_state);
   |                 ^^^ help: if this is intentional, prefix it with an underscore: `_ctx`
Raw output
infra/src/query_planner.rs:85:17:w:warning: unused variable: `ctx`
  --> infra/src/query_planner.rs:85:17
   |
85 |         let mut ctx = OptdPlanContext::new(session_state);
   |                 ^^^ help: if this is intentional, prefix it with an underscore: `_ctx`


__END__

Check warning on line 94 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L94

warning: unused variable: `optimizer`
  --> infra/src/query_planner.rs:94:17
   |
94 |         let mut optimizer = self.optimizer.lock().unwrap().take().unwrap();
   |                 ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_optimizer`
Raw output
infra/src/query_planner.rs:94:17:w:warning: unused variable: `optimizer`
  --> infra/src/query_planner.rs:94:17
   |
94 |         let mut optimizer = self.optimizer.lock().unwrap().take().unwrap();
   |                 ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_optimizer`


__END__

Check warning on line 85 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L85

warning: variable does not need to be mutable
  --> infra/src/query_planner.rs:85:13
   |
85 |         let mut ctx = OptdPlanContext::new(session_state);
   |             ----^^^
   |             |
   |             help: remove this `mut`
   |
   = note: `#[warn(unused_mut)]` on by default
Raw output
infra/src/query_planner.rs:85:13:w:warning: variable does not need to be mutable
  --> infra/src/query_planner.rs:85:13
   |
85 |         let mut ctx = OptdPlanContext::new(session_state);
   |             ----^^^
   |             |
   |             help: remove this `mut`
   |
   = note: `#[warn(unused_mut)]` on by default


__END__

Check warning on line 94 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L94

warning: variable does not need to be mutable
  --> infra/src/query_planner.rs:94:13
   |
94 |         let mut optimizer = self.optimizer.lock().unwrap().take().unwrap();
   |             ----^^^^^^^^^
   |             |
   |             help: remove this `mut`
Raw output
infra/src/query_planner.rs:94:13:w:warning: variable does not need to be mutable
  --> infra/src/query_planner.rs:94:13
   |
94 |         let mut optimizer = self.optimizer.lock().unwrap().take().unwrap();
   |             ----^^^^^^^^^
   |             |
   |             help: remove this `mut`


__END__

Check warning on line 27 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L27

warning: type `query_planner::DatafusionOptimizer` is more private than the item `query_planner::OptdPlanContext::optimizer`
  --> infra/src/query_planner.rs:27:5
   |
27 |     pub optimizer: Option<&'a DatafusionOptimizer>,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `query_planner::OptdPlanContext::optimizer` is reachable at visibility `pub(crate)`
   |
note: but type `query_planner::DatafusionOptimizer` is only usable at visibility `pub(self)`
  --> infra/src/query_planner.rs:22:1
   |
22 | struct DatafusionOptimizer {}
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^
   = note: `#[warn(private_interfaces)]` on by default
Raw output
infra/src/query_planner.rs:27:5:w:warning: type `query_planner::DatafusionOptimizer` is more private than the item `query_planner::OptdPlanContext::optimizer`
  --> infra/src/query_planner.rs:27:5
   |
27 |     pub optimizer: Option<&'a DatafusionOptimizer>,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `query_planner::OptdPlanContext::optimizer` is reachable at visibility `pub(crate)`
   |
note: but type `query_planner::DatafusionOptimizer` is only usable at visibility `pub(self)`
  --> infra/src/query_planner.rs:22:1
   |
22 | struct DatafusionOptimizer {}
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^
   = note: `#[warn(private_interfaces)]` on by default


__END__

Check warning on line 41 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L41

warning: type `query_planner::DatafusionOptimizer` is more private than the item `query_planner::OptdQueryPlanner::optimizer`
  --> infra/src/query_planner.rs:41:5
   |
41 |     pub optimizer: Arc<Mutex<Option<Box<DatafusionOptimizer>>>>,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `query_planner::OptdQueryPlanner::optimizer` is reachable at visibility `pub(crate)`
   |
note: but type `query_planner::DatafusionOptimizer` is only usable at visibility `pub(self)`
  --> infra/src/query_planner.rs:22:1
   |
22 | struct DatafusionOptimizer {}
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^
Raw output
infra/src/query_planner.rs:41:5:w:warning: type `query_planner::DatafusionOptimizer` is more private than the item `query_planner::OptdQueryPlanner::optimizer`
  --> infra/src/query_planner.rs:41:5
   |
41 |     pub optimizer: Arc<Mutex<Option<Box<DatafusionOptimizer>>>>,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `query_planner::OptdQueryPlanner::optimizer` is reachable at visibility `pub(crate)`
   |
note: but type `query_planner::DatafusionOptimizer` is only usable at visibility `pub(self)`
  --> infra/src/query_planner.rs:22:1
   |
22 | struct DatafusionOptimizer {}
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^


__END__

Check warning on line 107 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L107

warning: type `query_planner::DatafusionOptimizer` is more private than the item `query_planner::OptdQueryPlanner::new`
   --> infra/src/query_planner.rs:107:5
    |
107 |     pub fn new(optimizer: DatafusionOptimizer) -> Self {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `query_planner::OptdQueryPlanner::new` is reachable at visibility `pub(crate)`
    |
note: but type `query_planner::DatafusionOptimizer` is only usable at visibility `pub(self)`
   --> infra/src/query_planner.rs:22:1
    |
22  | struct DatafusionOptimizer {}
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^
Raw output
infra/src/query_planner.rs:107:5:w:warning: type `query_planner::DatafusionOptimizer` is more private than the item `query_planner::OptdQueryPlanner::new`
   --> infra/src/query_planner.rs:107:5
    |
107 |     pub fn new(optimizer: DatafusionOptimizer) -> Self {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `query_planner::OptdQueryPlanner::new` is reachable at visibility `pub(crate)`
    |
note: but type `query_planner::DatafusionOptimizer` is only usable at visibility `pub(self)`
   --> infra/src/query_planner.rs:22:1
    |
22  | struct DatafusionOptimizer {}
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^


__END__

Check warning on line 24 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L24

warning: fields `tables`, `session_state`, and `optimizer` are never read
  --> infra/src/query_planner.rs:25:5
   |
24 | pub struct OptdPlanContext<'a> {
   |            --------------- fields in this struct
25 |     tables: HashMap<String, Arc<dyn TableSource>>,
   |     ^^^^^^
26 |     session_state: &'a SessionState,
   |     ^^^^^^^^^^^^^
27 |     pub optimizer: Option<&'a DatafusionOptimizer>,
   |         ^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default
Raw output
infra/src/query_planner.rs:24:12:w:warning: fields `tables`, `session_state`, and `optimizer` are never read
  --> infra/src/query_planner.rs:25:5
   |
24 | pub struct OptdPlanContext<'a> {
   |            --------------- fields in this struct
25 |     tables: HashMap<String, Arc<dyn TableSource>>,
   |     ^^^^^^
26 |     session_state: &'a SessionState,
   |     ^^^^^^^^^^^^^
27 |     pub optimizer: Option<&'a DatafusionOptimizer>,
   |         ^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default


__END__

Check warning on line 44 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L44

warning: associated items `enable_adaptive`, `disable_adaptive`, and `new` are never used
   --> infra/src/query_planner.rs:45:12
    |
44  | impl OptdQueryPlanner {
    | --------------------- associated items in this implementation
45  |     pub fn enable_adaptive(&self) {
    |            ^^^^^^^^^^^^^^^
...
55  |     pub fn disable_adaptive(&self) {
    |            ^^^^^^^^^^^^^^^^
...
107 |     pub fn new(optimizer: DatafusionOptimizer) -> Self {
    |            ^^^
Raw output
infra/src/query_planner.rs:44:1:w:warning: associated items `enable_adaptive`, `disable_adaptive`, and `new` are never used
   --> infra/src/query_planner.rs:45:12
    |
44  | impl OptdQueryPlanner {
    | --------------------- associated items in this implementation
45  |     pub fn enable_adaptive(&self) {
    |            ^^^^^^^^^^^^^^^
...
55  |     pub fn disable_adaptive(&self) {
    |            ^^^^^^^^^^^^^^^^
...
107 |     pub fn new(optimizer: DatafusionOptimizer) -> Self {
    |            ^^^


__END__

Check warning on line 135 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L135

warning: enum `JoinOrder` is never used
   --> infra/src/query_planner.rs:135:6
    |
135 | enum JoinOrder {
    |      ^^^^^^^^^
Raw output
infra/src/query_planner.rs:135:6:w:warning: enum `JoinOrder` is never used
   --> infra/src/query_planner.rs:135:6
    |
135 | enum JoinOrder {
    |      ^^^^^^^^^


__END__

Check warning on line 155 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L155

warning: struct `OptdDfContext` is never constructed
   --> infra/src/query_planner.rs:155:12
    |
155 | pub struct OptdDfContext {
    |            ^^^^^^^^^^^^^
Raw output
infra/src/query_planner.rs:155:12:w:warning: struct `OptdDfContext` is never constructed
   --> infra/src/query_planner.rs:155:12
    |
155 | pub struct OptdDfContext {
    |            ^^^^^^^^^^^^^


__END__

Check warning on line 162 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L162

warning: function `create_df_context` is never used
   --> infra/src/query_planner.rs:162:14
    |
162 | pub async fn create_df_context(
    |              ^^^^^^^^^^^^^^^^^
Raw output
infra/src/query_planner.rs:162:14:w:warning: function `create_df_context` is never used
   --> infra/src/query_planner.rs:162:14
    |
162 | pub async fn create_df_context(
    |              ^^^^^^^^^^^^^^^^^


__END__

Check warning on line 4 in infra/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/main.rs#L4

warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
 --> infra/src/main.rs:4:41
  |
4 | use datafusion::execution::runtime_env::RuntimeConfig;
  |                                         ^^^^^^^^^^^^^
  |
  = note: `#[warn(deprecated)]` on by default
Raw output
infra/src/main.rs:4:41:w:warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
 --> infra/src/main.rs:4:41
  |
4 | use datafusion::execution::runtime_env::RuntimeConfig;
  |                                         ^^^^^^^^^^^^^
  |
  = note: `#[warn(deprecated)]` on by default


__END__

Check warning on line 15 in infra/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/main.rs#L15

warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
  --> infra/src/main.rs:15:21
   |
15 |     let rt_config = RuntimeConfig::new();
   |                     ^^^^^^^^^^^^^
Raw output
infra/src/main.rs:15:21:w:warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
  --> infra/src/main.rs:15:21
   |
15 |     let rt_config = RuntimeConfig::new();
   |                     ^^^^^^^^^^^^^


__END__

Check warning on line 15 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L15

warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
  --> infra/src/query_planner.rs:15:41
   |
15 | use datafusion::execution::runtime_env::RuntimeConfig;
   |                                         ^^^^^^^^^^^^^
Raw output
infra/src/query_planner.rs:15:41:w:warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
  --> infra/src/query_planner.rs:15:41
   |
15 | use datafusion::execution::runtime_env::RuntimeConfig;
   |                                         ^^^^^^^^^^^^^


__END__

Check warning on line 164 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L164

warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
   --> infra/src/query_planner.rs:164:23
    |
164 |     rn_config: Option<RuntimeConfig>,
    |                       ^^^^^^^^^^^^^
Raw output
infra/src/query_planner.rs:164:23:w:warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
   --> infra/src/query_planner.rs:164:23
    |
164 |     rn_config: Option<RuntimeConfig>,
    |                       ^^^^^^^^^^^^^


__END__

Check warning on line 181 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L181

warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
   --> infra/src/query_planner.rs:181:9
    |
181 |         RuntimeConfig::new()
    |         ^^^^^^^^^^^^^
Raw output
infra/src/query_planner.rs:181:9:w:warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
   --> infra/src/query_planner.rs:181:9
    |
181 |         RuntimeConfig::new()
    |         ^^^^^^^^^^^^^


__END__

Check warning on line 79 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L79

warning: unused variable: `verbose`
  --> infra/src/query_planner.rs:79:28
   |
79 |         let (mut explains, verbose, logical_plan) = match logical_plan {
   |                            ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_verbose`
   |
   = note: `#[warn(unused_variables)]` on by default
Raw output
infra/src/query_planner.rs:79:28:w:warning: unused variable: `verbose`
  --> infra/src/query_planner.rs:79:28
   |
79 |         let (mut explains, verbose, logical_plan) = match logical_plan {
   |                            ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_verbose`
   |
   = note: `#[warn(unused_variables)]` on by default


__END__

Check warning on line 85 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L85

warning: unused variable: `ctx`
  --> infra/src/query_planner.rs:85:17
   |
85 |         let mut ctx = OptdPlanContext::new(session_state);
   |                 ^^^ help: if this is intentional, prefix it with an underscore: `_ctx`
Raw output
infra/src/query_planner.rs:85:17:w:warning: unused variable: `ctx`
  --> infra/src/query_planner.rs:85:17
   |
85 |         let mut ctx = OptdPlanContext::new(session_state);
   |                 ^^^ help: if this is intentional, prefix it with an underscore: `_ctx`


__END__

Check warning on line 94 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L94

warning: unused variable: `optimizer`
  --> infra/src/query_planner.rs:94:17
   |
94 |         let mut optimizer = self.optimizer.lock().unwrap().take().unwrap();
   |                 ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_optimizer`
Raw output
infra/src/query_planner.rs:94:17:w:warning: unused variable: `optimizer`
  --> infra/src/query_planner.rs:94:17
   |
94 |         let mut optimizer = self.optimizer.lock().unwrap().take().unwrap();
   |                 ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_optimizer`


__END__

Check warning on line 85 in infra/src/query_planner.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/query_planner.rs#L85

warning: variable does not need to be mutable
  --> infra/src/query_planner.rs:85:13
   |
85 |         let mut ctx = OptdPlanContext::new(session_state);
   |             ----^^^
   |             |
   |             help: remove this `mut`
   |
   = note: `#[warn(unused_mut)]` on by default
Raw output
infra/src/query_planner.rs:85:13:w:warning: variable does not need to be mutable
  --> infra/src/query_planner.rs:85:13
   |
85 |         let mut ctx = OptdPlanContext::new(session_state);
   |             ----^^^
   |             |
   |             help: remove this `mut`
   |
   = note: `#[warn(unused_mut)]` on by default


__END__