Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project proposals for Prometheus #1326

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

ArthurSens
Copy link
Contributor

Creating it as a draft since we're still figuring out the details for the second project :)

Signed-off-by: Arthur Silva Sens <[email protected]>
@ArthurSens ArthurSens marked this pull request as ready for review January 27, 2025 16:25
Copy link
Contributor

@AndrejKiri AndrejKiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArthurSens Done. Added a couple of small suggestions. Nothing serious. Feel free to reject if it doesn't make sense. 😉

Co-authored-by: Andrej Kiripolský <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @ArthurSens!

@amy-super, @AndrejKiri, I see you've each approved this PR to confirm participation, thanks for that! Arthur, we prefer to have more than one mentor per project, is there someone who could join your first project?

(edit to acknowledge approvals 😅)

@ArthurSens
Copy link
Contributor Author

Hi Nate, unfortunately @dashpole and I are the only maintainers for this piece of code and David won't be available this time.

Would it be ok if I'm the only mentor?

@nate-double-u
Copy link
Member

Would it be ok if I'm the only mentor?

Thanks, I think it'll be fine in this case, thanks for clarifying 😊

@nate-double-u nate-double-u merged commit 5384394 into cncf:main Jan 29, 2025
2 checks passed
@ArthurSens ArthurSens deleted the lfx-2025-prometheus branch January 30, 2025 11:39
@nate-double-u
Copy link
Member

Sorry i missed this @ArthurSens, is there an upstream issue for UX Research: How users expect to use OTLP Resource Attributes in Prometheus? Or something I can use to point to when I open the LFX project?

@ArthurSens
Copy link
Contributor Author

ArthurSens commented Jan 30, 2025

Yeah.... I wasn't sure what to put over there. The reality is that we've already implemented something to handle Resource attributes. Still, as people started to use it we're facing several minor UX problems for so many personas of Prometheus users. I think the most generic one is this prometheus/prometheus#12629, but it doesn't list all our UX problems.

What is the goal of the issue? To be a place where candidates can learn more about the problem? Or to fulfill a form? If we just need to put something out there, let's use the one above. If it's supposed to give information about the problems, I'd recommend reading:

I think this still doesn't list all the problems, which I hope the research will do a better job at, but it could be a good starting point :)

@nate-double-u
Copy link
Member

nate-double-u commented Jan 30, 2025

2 things: it gives me something to link to when I create the project over on LFX, and it's good practice to have a place where folks can discuss the project during the application phase, and where you can discuss design and development during the program. If you don't have a dedicated upstream issue i've found that folks will ask about the mentorship in random places, and that can be hard to manage.

WasmEdge has some good examples: WasmEdge LFX Mentorship issues

@ArthurSens
Copy link
Contributor Author

I see! We definitely need to organize our work on the Prometheus side, I'll try to come up with ideas with the team to have something similar to what WasmEdge has. Today we kinda come up with ideas at the last minute and we don't get much prepared in advance :(

I've just created this one: prometheus/prometheus#15909. I'll try to organize things in advance for the next ones!

@nate-double-u
Copy link
Member

Thanks! I'll use that issue, and will update the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants