Fix scope of CMake Policy variables #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanBruens
force-pushed
the
fix_cmake_policy
branch
from
0f163ee to
92ad8e7
Compare
Commit 7d47760 ("moving some settings to an apposite cmake file") moved the `cmake_policy(SET CMP0072 NEW)` from the toplevel scope to the scope of the included file. For details, see https://cmake.org/cmake/help/latest/manual/cmake-policies.7.html Set NO_POLICY_SCOPE when including the file, to move the POLICIES back to the toplevel scope. Also remove the extra cmake_minimum_version from external/CMakeLists.txt, as it implicitly calls `cmake_policy(VERSION 3.10)`, resetting any policies introduced with cmake 3.11 and newer (i.e. CMP0072). Fixes cnr-isti-vclab#1095.
StefanBruens
force-pushed
the
fix_cmake_policy
branch
from
92ad8e7 to
16e7f69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 7d47760 ("moving some settings to an apposite cmake file")
moved the
cmake_policy(SET CMP0072 NEW)from the toplevel scope to thescope of the included file. For details, see
https://cmake.org/cmake/help/latest/manual/cmake-policies.7.html
Set NO_POLICY_SCOPE when including the file, to move the POLICIES back
to the toplevel scope.
Fixes #1095.