Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user controller - add swagger annotation, exception handling controller->service #35

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

ssoheeh
Copy link
Collaborator

@ssoheeh ssoheeh commented Jan 25, 2025

Features

Chore

  • user controller swagger annotation 추가
  • exception handling controller -> service layer 에서 처리

Verified

This commit was signed with the committer’s verified signature.
ns-rse Neil Shephard
@ssoheeh ssoheeh requested a review from Zerohertz as a code owner January 25, 2025 11:53
@ssoheeh ssoheeh linked an issue Jan 25, 2025 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 23.36%. Comparing base (b120ccd) to head (1c87cd1).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...va/com/server/domain/user/service/UserService.java 8.33% 11 Missing ⚠️
.../server/domain/user/controller/UserController.java 0.00% 4 Missing ⚠️
@@             Coverage Diff              @@
##               main      #35      +/-   ##
============================================
- Coverage     24.86%   23.36%   -1.50%     
+ Complexity       40       38       -2     
============================================
  Files            39       39              
  Lines           366      368       +2     
  Branches         17       17              
============================================
- Hits             91       86       -5     
- Misses          275      282       +7     
Components Coverage Δ
user ∅ <ø> (∅)
Files with missing lines Coverage Δ Complexity Δ
.../server/domain/user/controller/UserController.java 9.09% <0.00%> (+4.09%) 1.00 <0.00> (ø)
...va/com/server/domain/user/service/UserService.java 58.82% <8.33%> (-41.18%) 9.00 <1.00> (-1.00)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d91f21b...1c87cd1. Read the comment docs.

Verified

This commit was signed with the committer’s verified signature.
ns-rse Neil Shephard

Verified

This commit was signed with the committer’s verified signature.
ns-rse Neil Shephard
@Zerohertz Zerohertz merged commit e2fb7fe into main Jan 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: user & oauth
2 participants