Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DuplicateFileBear.py: Applying IgnoreResultAction gives error #2945

Open
akshatkarani opened this issue Aug 7, 2019 · 0 comments · May be fixed by #2947
Open

DuplicateFileBear.py: Applying IgnoreResultAction gives error #2945

akshatkarani opened this issue Aug 7, 2019 · 0 comments · May be fixed by #2947

Comments

@akshatkarani
Copy link
Member

akshatkarani commented Aug 7, 2019 •
edited
Loading

Applying IgnoreResultAction on results originating from DuplicateFileBear gives the following error

**** DuplicateFileBear [Section: duplicate | Severity: INFO] ****
!    ! File /home/akshat/coala-repos/coala-tutorial/src/add.py is identical to File /home/akshat/coala-repos/coala-tutorial/src/dup_add.py
[    ] *0. Do (N)othing
[    ]  1. (O)pen file
[    ]  2. Add (I)gnore comment
[    ] Enter number (Ctrl-D to exit): 2
[ERROR][19:02:50] Failed to execute the action IgnoreResultAction with error: '/home/akshat/coala-repos/coala-tutorial/src/add.py'.

IgnoreResultAction should not even be applicable in this since DuplicateFileBear is a GlobalBear. It is applicable because of the file argument passed when it is yielded. Removing it should fix it.
akshatkarani added a commit to akshatkarani/coala-bears that referenced this issue Aug 9, 2019
@akshatkarani
DuplicateFileBear.py: Remove file argument
993e86c 
This removes the file argument when result is yielded.

Fixes coala#2945
@akshatkarani akshatkarani linked a pull request Aug 12, 2019 that will close this issue
Open
akshatkarani added a commit to akshatkarani/coala-bears that referenced this issue Aug 25, 2019
@akshatkarani
DuplicateFileBear.py: Remove file argument
e7c209f 
This removes the file argument when result is yielded.

Fixes coala#2945
akshatkarani added a commit to akshatkarani/coala-bears that referenced this issue Sep 19, 2019
@akshatkarani
DuplicateFileBear.py: Remove file argument
bf25a18 
This removes the file argument when result is yielded.

Fixes coala#2945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DeleteFileAction: New action for DuplicateFileBear akshatkarani/coala-bears
1 participant
@akshatkarani