Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeleteFileAction: New action for DuplicateFileBear #2947

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

akshatkarani
Copy link
Member

This removes the file argument when the result is yielded from DuplicateFileBear.
Fixes #2945

This also adds a new action for DuplicateFileBear, DeleteFileAction.

@akshatkarani
Copy link
Member Author

Temp changes commit is for CI because this PR depends on coala/coala#6029

@@ -91,7 +91,7 @@ function Install-coala {

Checkpoint-Pip-Constraints

Install-Pip-Requirement 'git+https://github.com/coala/coala#egg=coala'
Install-Pip-Requirement 'git+https://github.com/akshatkarani/coala@nextgen#egg=coala'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose Temp changes can be removed now since coala/coala#6029 is merged

This removes the file argument when result is yielded.

Fixes coala#2945
Added a new action DeleteFileAction for DuplicateFileBear. Two instances
of this action are added corresponding to the files. On applying it will
delete one the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

DuplicateFileBear.py: Applying IgnoreResultAction gives error
2 participants