Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAQ.rst: Information about one test is missing #580

Open
shashank-b opened this issue Dec 11, 2018 · 6 comments · May be fixed by #591
Open

FAQ.rst: Information about one test is missing #580

shashank-b opened this issue Dec 11, 2018 · 6 comments · May be fixed by #591
Assignees
@aliasgar12
Labels
area/documentation difficulty/newcomer

Comments

@shashank-b
Copy link
Member

In the section "What are those things failing/passing on my Pull Request?" in Help/FAQ.rst, only 6 out of the 7 tests have been mentioned.

Adding the missing test to the bulleted list or changing the contents of the section appropriately would fix this.
@ar20603
Copy link

ar20603 commented Dec 13, 2018

Can i be assigned to fix this? I am new here. Also tell me how am i supposed to fix this? Should 7 be simply changed to 6 or if there is any point to add to the list?

@shashank-b
Copy link
Member Author

@ar20603, the maintainers would assign this to you and invite you to the organization soon. I'd suggest that you go through any previously opened PR in Coala. You'll be able to see the list of tests there.

@aliasgar12
Copy link

Can I be assigned this issue ?

@aliasgar12
Copy link

aliasgar12 commented Jan 8, 2019 •
edited
Loading

I went through few of the open pull request and found out that the following checks were missing from the FAQ list for the question "What are those things failing/passing on my Pull Request?" -

  1. continuous-integration/travis-ci/pr
  2. deploy/netlify
  3. review/gitmate/manual/pr

Please advise which ones need to be added. Also, since I am unaware of their functionalities, how can I write a proper description for these ?

@shashank-b
Copy link
Member Author

shashank-b commented Jan 9, 2019 •
edited
Loading

Hey @aliasgar12
Please work on review/gitmate/manual/pr for this PR, as none of the existing points cover anything remotely related to it.
For the description part, it is quite similar to review/gitmate/manual and you can get a clearer idea by looking at some unapproved and approved PRs and reading about the Review process. If you still have any questions, be sure to drop a message on the gitter channel.

@aliasgar12
Copy link

Thank you @shashank-b . I will let you know if I have anymore questions.

aliasgar12 added a commit to aliasgar12/documentation that referenced this issue Jan 14, 2019
@aliasgar12
FAQ.rst : Adding information about missing test.
26f39a5 
Adding ``review/gitmate/manual/pr`` to the list
of tests that are executed before any pull
request is approved.
Closes coala#580
@aliasgar12 aliasgar12 linked a pull request Jan 14, 2019 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aliasgar12 aliasgar12

Labels
area/documentation difficulty/newcomer
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FAQ.rst : Adding information about missing test. aliasgar12/documentation
4 participants
@gitmate-bot @shashank-b @aliasgar12 @ar20603