FAQ.rst : Adding information about missing test. #591
Conversation
Adding ``review/gitmate/manual/pr`` to the list of tests that are executed before any pull request is approved. Closes coala#580
| @@ -136,6 +136,11 @@ our master branch. Right now we use 7 of those checks: | |||
| it all documented | |||
| `here <http://api.coala.io/en/latest/Developers/Review.html>`_. | |||
|
|
|||
| - **review/gitmate/manual/pr** This is a manual process in which the pull request | |||
| can be reviewed by any coala member. Once the pull request is reviewed and | |||
There was a problem hiding this comment.
Line contains following spacing inconsistencies:
- Trailing whitespaces.
Origin: SpaceConsistencyBear, Section: docs.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpx3uh_vlp/Help/FAQ.rst
+++ b/tmp/tmpx3uh_vlp/Help/FAQ.rst
@@ -137,7 +137,7 @@
`here <http://api.coala.io/en/latest/Developers/Review.html>`_.
- **review/gitmate/manual/pr** This is a manual process in which the pull request
- can be reviewed by any coala member. Once the pull request is reviewed and
+ can be reviewed by any coala member. Once the pull request is reviewed and
approved, it is ready to be merged into the master branch. Post approval, it will
be labeled with a ``process`` label marked as ``approved``.
| @@ -136,6 +136,11 @@ our master branch. Right now we use 7 of those checks: | |||
| it all documented | |||
| `here <http://api.coala.io/en/latest/Developers/Review.html>`_. | |||
|
|
|||
| - **review/gitmate/manual/pr** This is a manual process in which the pull request | |||
| can be reviewed by any coala member. Once the pull request is reviewed and | |||
| approved, it is ready to be merged into the master branch. Post approval, it will | |||
There was a problem hiding this comment.
Line contains following spacing inconsistencies:
- Trailing whitespaces.
Origin: SpaceConsistencyBear, Section: docs.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpx3uh_vlp/Help/FAQ.rst
+++ b/tmp/tmpx3uh_vlp/Help/FAQ.rst
@@ -138,7 +138,7 @@
- **review/gitmate/manual/pr** This is a manual process in which the pull request
can be reviewed by any coala member. Once the pull request is reviewed and
- approved, it is ready to be merged into the master branch. Post approval, it will
+ approved, it is ready to be merged into the master branch. Post approval, it will
be labeled with a ``process`` label marked as ``approved``.
- **codecov/project** This one checks whether all your code is being tested. We
| @@ -136,6 +136,11 @@ our master branch. Right now we use 7 of those checks: | |||
| it all documented | |||
| `here <http://api.coala.io/en/latest/Developers/Review.html>`_. | |||
|
|
|||
| - **review/gitmate/manual/pr** This is a manual process in which the pull request | |||
There was a problem hiding this comment.
Line is longer than allowed. (81 > 79)
Origin: LineLengthBear, Section: docs.
| @@ -136,6 +136,11 @@ our master branch. Right now we use 7 of those checks: | |||
| it all documented | |||
| `here <http://api.coala.io/en/latest/Developers/Review.html>`_. | |||
|
|
|||
| - **review/gitmate/manual/pr** This is a manual process in which the pull request | |||
| can be reviewed by any coala member. Once the pull request is reviewed and | |||
| approved, it is ready to be merged into the master branch. Post approval, it will | |||
There was a problem hiding this comment.
Line is longer than allowed. (84 > 79)
Origin: LineLengthBear, Section: docs.
There was a problem hiding this comment.
Hey @aliasgar12
Please run coala on your code and also change your commit message according to the commit guidelines.
Besides, the content that you added is also not completely correct. Please read http://api.coala.io/en/latest/Developers/Review.html and look at some currently open or closed PRs for more clarity. (For eg. Not every member can get the PR ready to be merged)
@shashank-b I will fix this and re-commit accordingly. Thanks |
|
Sorry @aliasgar12, you do not have the necessary permission levels to perform the action. |
Adding
review/gitmate/manual/prto the listof tests that are executed before any pull
request is approved.
Closes #580
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
corobo mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!