-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logo.html: Make header icon responsive #592
base: master
Are you sure you want to change the base?
Conversation
@shashank-b please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow commit guidelines and then amend
your commit message.
cc98e79
to
e6b6466
Compare
@Dhiraj240 please check now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please read the link properly.You haven't followed it, add issue reference.
e6b6466
to
35c9aa2
Compare
_static/logo.html
Outdated
<div class="coala-logo-doc-low"> | ||
<img width="187.5px" height="187.5px" src="_static/images/coala_logo.svg"> | ||
</div> | ||
</body> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add EOL at EOF
35c9aa2
to
e2e3293
Compare
e2e3293
to
c594df2
Compare
logo.html: Display header according to screen width Now bear-header is rendered according to screen-width. Closes coala/landing-frontend#299
c594df2
to
e5597d8
Compare
@jayvdb please check now |
@sangamcse can you take a look at this. We should be probably doing this in the artwork repo, and sync'ing here, etc? |
.. image:: _static/images/coala-header.png | ||
:scale: 50 | ||
:align: center | ||
.. raw:: html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if we can add SVG here or not.
Makes the header icon of docs.coala.io more responsive.
Closes coala/landing-frontend#299
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
them.
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
corobo mark wip <URL>
to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!