-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mGBA: add Ubuntu script #152
base: master
Are you sure you want to change the base?
Conversation
756de1c should prevent this from causing any issues.
|
Oh interesting, does the
|
I think the flag to disable mGBA completely is -DENABLE_MGBA or something. If QT6 isn't supported yet don't worry about it - I figured if that WAS supported the script would be futureproof for longer if it was built with that over QT5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think you forgot to take out the redundant error function definition during your testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really sure what it does, most of the script is copied over from melonDS and this is present there (link)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's my fault, then - it's a duplicate from functions.sh
Will remove from melonDS in a moment
I do not feel there is any benefit to the inclusion of this script to the Megascript when mGBA is already available on flathub. It is just additional maintenance burden. For users that want to build this emulator from source for development purposes that is what the documentation at the emulator's official github is for. The pre-existing emulators on the Megascript were added either:
|
I've got no issue allowing it in, personally - particularly when Flathub support doesn't work correctly 100% of the time. More options are a good thing - and something like mGBA is probably pretty low maintenance. We can always reduce the maintenance burden a bit by checking if the system repos have the newest release available. |
Maintenance burden is too high for 18.04 I am not (and have not for a year) been maintaining anything for it in mind and neither has CTCaer. |
Sure, 18.04 is a pain, but me hitting the merge button on this is me saying I'll maintain support for it - you don't have to. I'm still interested in keeping the scripts I built for it working on stuff that old as a convenience for anyone still using those environments. |
Removed the error function in case we want to move forward with merging, I have no preference either way. |
This adds a script for mGBA, a Game Boy, Game Boy Color and Game Boy Advance emulator.
Only tested for Kubuntu 24.04.