Fix test failures in CI #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhyNotHugo
changed the title
Previously, tox would attempt to run all pre-defined versions of Python and ignore the system-wide python. Given that each CI job has a single, explicitly specified, Python version installed use that version.
The implementation for `get_username` only tried some environment variables which are undefined in our CI environment.
Fixes authentication tests for Python >= 3.12. See: #95
Both of 3.6 and 3.7 are deprecated, and the former is no longer available in GH Actions.
|
This brings CI to a green state (without including any new Python versions). @cocagne: unless you have any comments on this, I'll go ahead and merge it before starting work on newer versions of Python. |
|
Looks good to me. Go ahead and merge.
…On Mon, Jul 22, 2024 at 4:27 AM Hugo ***@***.***> wrote:
This brings CI to a green state (without including any new Python
versions).
@cocagne <https://github.com/cocagne>: unless you have any comments on
this, I'll go ahead and merge it before starting work on newer versions of
Python.
—
Reply to this email directly, view it on GitHub
<#98 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANMW7APZVQLBAVQ4YA6SIDZNTF77AVCNFSM6AAAAABLH4X5YSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBSGUYDCOBTHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit descriptions.