Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues-review: Add option to close stale issues #526

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

marusak
Copy link
Member

@marusak marusak commented Feb 13, 2020

I tested it with my repo:
issue 1
issue 2
issue 3

One issue was closed as enhancement, one as bug or enhancement and one was not closed as expected. It also checks for bug label, which we don't use, but maybe we can be better in this and actually label bugs.

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just some grammar nitpicks, otherwise LGTM.

issues-review Outdated
"""

rfe_msg = """
This issue is closed due to inactivity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing period.

bug_msg = """
This issue is closed due to inactivity.

If you are still able to reproduce it, please comment here and provide us with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with "an" updated reproducer.

issues-review Outdated
This issue is closed due to inactivity.

If this issue is a bug report and you are still able to reproduce it, please
comment here and provide us with updated reproducer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with "an" updated..

issues-review Outdated
If this issue is a bug report and you are still able to reproduce it, please
comment here and provide us with updated reproducer.

If this issue is request for a new feature, we are sorry but we won't be able
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is "a" request
sorry"," but

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@martinpitt martinpitt merged commit c433610 into cockpit-project:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants