Makefile: Update Cockpit lib to 035dc2d9be846320bbe4b2be75c32277 #1914
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
changed the title
allisonkarlitskaya
force-pushed
the
cockpit-lib-update-cockpit-lib-20241121-025039
branch
from
965f594 to
8e4f429
Compare
|
Hmm, I would have thought the multihost warning dialogs only affect the shell, not pkg/lib, but that test is broken very consistently. |
|
Wait, didn't I just fix that in #1915 ? Let's try and rebase. |
martinpitt
force-pushed
the
cockpit-lib-update-cockpit-lib-20241121-025039
branch
from
8e4f429 to
85d7a18
Compare
|
Nope, didn't help, still failing. |
|
The tests fail because testlib was updated to handle the new refactored host switcher logic in f06b13a4c4 but that only works for Cockpit 329. Our images still have Cockpit 327 which means we have to pass the option which enables the old behaviour. We should have added this check in |
|
Looks like it going green \o/ |
|
https://cockpit-logs.us-east-1.linodeobjects.com/pull-1914-a6bf6b4c-20241125-162813-opensuse-tumbleweed/log.html#91 still fails on that problem 😢 the other two look like flakes, retrying. |
With the release of Cockpit 329 the add host dialog now warns the user before adding a remote host. Cockpit's testlib add host helper function defaults to this behaviour but our test images still have an older version of Cockpit installed.
jelly
force-pushed
the
cockpit-lib-update-cockpit-lib-20241121-025039
branch
from
a6bf6b4 to
9ff3738
Compare
|
this failure is annoying: That triggers a very strong déjà vu, @mvollmer recently fixed something very similar, or the same (but I can't find it now). Pretty sure it's a flake, but retrying to be safe. |
|
I get it -- this starts with the NFS SNAFU cockpit-project/bots#7137, so this needs naughties. And then browser is valid, but cockpit was never actually loaded (it's blank). That needs a machines fix. But that's independent. It failed the same way in other PRs, so let's get this out of the way. |
martinpitt
deleted the
cockpit-lib-update-cockpit-lib-20241121-025039
branch
| @@ -68,7 +68,8 @@ class TestMultiMachineVNC(VirtualMachinesCase): | |||
| self.goToVmPage(name) | |||
| b.wait_in_text(f"#vm-{name}-system-state", "Running") | |||
|
|
|||
| b.add_machine(m2_host, known_host=True, password=None) | |||
| # Cockpit 329 warns the user before adding a remote host | |||
There was a problem hiding this comment.
No, it doesn't. We explicitly switch the warning off.
Aditya Vardhan Singh (1):
shell: style login close button as secondary button
Jelle van der Waa (4):
lib: cockpit: remove cockpit.resolve/cockpit.reject()
lib: cockpit: remove cockpit.when()
lib: cockpit: make resolve_dot_paths always return an array
pkg: lib: robustify self.path initialisation for cockpit.location
Marius Vollmer (1):
shell: Require confirmation before connecting to remote machines
Martin Pitt (5):
lib: Ignore invalid input keys in Terminal
test: Add support for querying shadow DOM
lib: Eliminate ModificationsExportDialog show property
lib: Make cockpit-components-modifications Ansible optional
test: Avoid scrolling race with session menu