New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json: ipaddr.js is a runtime dependency #1978

Merged

jelly merged 1 commit into cockpit-project:main from jelly:ipaddr.js-runtime-dep

Jan 16, 2025

Member

jelly commented Jan 16, 2025

This was wrongly added as devDependencies while it is a runtime dependency.

src/components/networks/utils.js:import * as ipaddr from "ipaddr.js";


          package.json: ipaddr.js is a runtime dependency

df420f2

This was wrongly added as devDependencies while it is a runtime
dependency.

jelly requested a review from martinpitt

January 16, 2025 10:49

martinpitt approved these changes

View reviewed changes

Member

martinpitt left a comment

Oops, thanks for spotting!

jelly merged commit fda7ae5 into cockpit-project:main

28 checks passed

jelly deleted the ipaddr.js-runtime-dep branch

January 16, 2025 12:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet