Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Let make rebuild the bundle on PO changes #21529

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

martinpitt
Copy link
Member

Fixes #19406


Before:

$ touch po/de.po; make
make  all-am
make[1]: Entering directory '/var/home/martin/upstream/cockpit/main'
make[1]: Leaving directory '/var/home/martin/upstream/cockpit/main'

Now:

make  all-am
make[1]: Entering directory '/var/home/martin/upstream/cockpit/main'
  BUNDLE   dist
12:03:23: Build finished
  COPY     dist/static/fonts/RedHatText-Regular.woff2 → doc/guide/html/
  COPY     dist/static/fonts/RedHatText-Medium.woff2 → doc/guide/html/
  GEN      doc/guide/html/index.html
make[1]: Leaving directory '/var/home/martin/upstream/cockpit/main'

@martinpitt martinpitt added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Jan 17, 2025
Copy link
Member

@jelly jelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinpitt martinpitt merged commit 4f7d4fb into cockpit-project:main Jan 17, 2025
31 of 32 checks passed
@martinpitt martinpitt deleted the build-po branch January 17, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test For doc/workflow changes, or experiments which don't need a full CI run,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make should re-run ./build.js on changes to po/, possibly others
2 participants