Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add bootc image #21559

Merged
merged 5 commits into from
Jan 31, 2025
Merged

test: Add bootc image #21559

merged 5 commits into from
Jan 31, 2025

Conversation

martinpitt
Copy link
Member

@martinpitt martinpitt commented Jan 28, 2025

We want to test deploying cockpit rpms in bootc images. This will prevent hiccups like #21201 in the future and also test a lot of OS subsystems.

The centos-9-bootc bots image includes its own deployment container image, so we can easily derive an image with our locally built RPMs included.

https://issues.redhat.com/browse/COCKPIT-1237


Note that I only cover/trigger centos-9-bootc/{networking,other,expensive} here. /storage requires adding cockpit-storaged, udisks, etc., which we skip on fedora-coreos as well. Managing storage isn't the most important thing on a bootc system, so I'll left that for a follow-up.

Prerequisites/split out work:

@martinpitt martinpitt added blocked Don't land until something else happens first (see task list) no-test For doc/workflow changes, or experiments which don't need a full CI run, labels Jan 28, 2025
@martinpitt martinpitt changed the title test: Add bootc image preparation test: Add bootc image Jan 29, 2025
@martinpitt martinpitt force-pushed the bootc-test branch 2 times, most recently from 837aaf1 to 6be0410 Compare January 29, 2025 10:58
On RHEL 9 (although only on bootc, curiously), systemd sometimes has
trouble with cleaning up beiboot's temp files:

> avc:  denied  { remove_name } for  pid=1 comm="systemd" name="user-known-hosts" dev="tmpfs" ino=77 scontext=system_u:system_r:init_t:s0 tcontext=system_u:object_r:cockpit_tmp_t:s0 tclass=dir permissive=0

Allow this, this is harmless enough.
@martinpitt martinpitt removed blocked Don't land until something else happens first (see task list) no-test For doc/workflow changes, or experiments which don't need a full CI run, labels Jan 30, 2025
Whether pam_ssh_add is available or not depends on whether we use
cockpit-ws.rpm or the ws container; not if the image is OSTree or not.
The difference matters on centos-9-bootc.
MD5 keys haven't been a thing any more for many years.
@martinpitt martinpitt marked this pull request as ready for review January 30, 2025 13:56
We want to test deploying cockpit rpms in bootc images. This will
prevent hiccups like
cockpit-project#21201 in the future
and also test a lot of OS subsystems.

The centos-9-bootc bots image includes its own deployment container
image, so we can easily derive an image with our locally built RPMs
included.

https://issues.redhat.com/browse/COCKPIT-1237
@jelly jelly merged commit 762c350 into cockpit-project:main Jan 31, 2025
88 checks passed
@martinpitt martinpitt deleted the bootc-test branch January 31, 2025 09:55
martinpitt added a commit to martinpitt/bots that referenced this pull request Jan 31, 2025
mvollmer pushed a commit to cockpit-project/bots that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants