client: Conditionally remove workaround for UDisks2 issue 1206 #21595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvollmer
force-pushed
the
storage-remove-crpytoraid-workaround
branch
3 times, most recently
from
5eea440 to
51530f1
Compare
mvollmer
force-pushed
the
storage-remove-crpytoraid-workaround
branch
from
51530f1 to
61a52cb
Compare
mvollmer
changed the title
mvollmer
force-pushed
the
storage-remove-crpytoraid-workaround
branch
2 times, most recently
from
ab081b2 to
17f789f
Compare
It's fixed in 2.11, but that isn't released yet. Also fix the test to use two PVs. Cockpit will not show how a logical volume is stored when there is only one PV. Also test the expected behavior with old versions of UDisks2. (Also, rename older_than to younger_than, because that is what it implements.)
mvollmer
force-pushed
the
storage-remove-crpytoraid-workaround
branch
from
17f789f to
aed4b8e
Compare
|
Nice, now TestStorageLvm2.testLvmOnLuks succeeds and does not get skipped on cockpit-project/bots#5434 any more. I triggered an additional fedora-41/daily-storage run - as far as I understand, this should get udisks 2.11 and also pass? |
martinpitt
approved these changes
Feb 27, 2025
Yes. It did run already as fedora-42/daily-storage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.