Update Openshift Release Process #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prafull01
force-pushed
the
openshift-rel
branch
2 times, most recently
from
7d11ffe to
e61f314
Compare
pseudomuto
reviewed
Apr 11, 2023
| docker push $image | ||
| run_preflight() { | ||
| bazel build //hack/bin:preflight | ||
| PFLT_PYXIS_API_TOKEN="${REDHAT_API_TOKEN}" bazel-bin/hack/bin/preflight \ |
There was a problem hiding this comment.
Is this token already in place in TC?
There was a problem hiding this comment.
I am not sure. I don't have access to TC. Can you please check in the TC if we have added this token
There was a problem hiding this comment.
I didn't see it there. Maybe worth asking @rail just to be sure.
There was a problem hiding this comment.
REDHAT_API_TOKEN is set in TeamCity, correct.
prafull01
commented
Apr 11, 2023
prafull01
force-pushed
the
openshift-rel
branch
from
62340a8 to
4e375f9
Compare
|
Tests is passing locally. Logs points to the following issue in GitHub actions actions/runner#2468 and has been seen by many people recently |
prafull01
force-pushed
the
openshift-rel
branch
from
4e375f9 to
68f64b9
Compare
pseudomuto
approved these changes
May 16, 2023
Adding preflight to the list of OpenShift binaries installed. For now, this is only available on Linux machines and won't be added to anyone using Darwin.
Updating the build/release scripts to handle publishing the bundle images and running preflight on them. The publish-openshift script downloads the tagged release from DockerHub, retags it correctly for the RedHat scanning repo, pushes it, and finally runs the preflight check on it. The openshift-bundle script largely does the same, only it publishes the bundle image rather than the operator image. The same script is used for both the certified and marketplace bundles. Passing `MARKETPLACE=1` will use the marketplace bundle values rather than the certified ones (default).
Updated all of the outdated OpenShift binaries. This also includes a fix to an issue with had with opm. We were copying the tar file into the bin folder and marking it as executable. This naturally, caused issues when we tried to run it.
Adding targets for running preflight tests. These only work on Linux machines since preflight is currently not available on other platforms. The preflight tasks all assume you've got a running OpenShift cluster and that GCP_PROJECT and KUBECONFIG are set accordingly in the env.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install preflight binary on Linux machines
Publish operator and bundle images for RedHat/OpenShift
Support Openshift version 4.10 and 4.11 as we have support for k8s 1.25
Fixes: #938
Checklist