Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup: TestDataDriven_restore_validation_only failed #140550

Closed
github-actions bot opened this issue Feb 5, 2025 · 3 comments · Fixed by #140676
Closed

backup: TestDataDriven_restore_validation_only failed #140550

github-actions bot opened this issue Feb 5, 2025 · 3 comments · Fixed by #140676
Assignees
Labels
A-disaster-recovery branch-master Failures and bugs on the master branch. branch-release-25.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-1 Issues/test failures with a fix SLA of 1 month T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@github-actions
Copy link

github-actions bot commented Feb 5, 2025

backup.TestDataDriven_restore_validation_only failed on master @ f18cf53e67c1c6eab453eb7be40743b86cdbf349:

=== RUN   TestDataDriven_restore_validation_only
    test_log_scope.go:165: test logs captured to: outputs.zip/logTestDataDriven_restore_validation_only183859332
    test_log_scope.go:76: use -show-logs to present logs inline
    datadriven_test.go:447: Mock HTTP Storage "http://127.0.0.1:35195"
    test_server_shim.go:154: automatically injected a shared process virtual cluster under test; see comment at top of test_server_shim.go for details.
    datadriven.go:144: 
        /var/lib/engflow/worker/work/2/exec/bazel-out/k8-fastbuild/bin/pkg/backup/backup_test_/backup_test.runfiles/com_github_cockroachdb_cockroach/pkg/backup/testdata/backup-restore/restore-validation-only:9:
        new-cluster [2 args]
        <no input to command>
        ----
    datadriven.go:144: 
        /var/lib/engflow/worker/work/2/exec/bazel-out/k8-fastbuild/bin/pkg/backup/backup_test_/backup_test.runfiles/com_github_cockroachdb_cockroach/pkg/backup/testdata/backup-restore/restore-validation-only:12:
         CREATE DATABASE d;
        CREATE TYPE d.greeting AS ENUM ('hello', 'howdy', 'hi');
        CREATE TABLE d.t1 (x INT);
        INSERT INTO d.t1 VALUES (1), (2), (3);
        CREATE TABLE d.t2 (x d.greeting);
        INSERT INTO d.t2 VALUES ('hello'), ('howdy');
        COMMENT ON TABLE d.t1 IS 'This comment better get restored from the backed up system table!';
        expected:
        NOTICE: auto-committing transaction before processing DDL due to autocommit_before_ddl setting
        NOTICE: auto-committing transaction before processing DDL due to autocommit_before_ddl setting
        NOTICE: auto-committing transaction before processing DDL due to autocommit_before_ddl setting
        NOTICE: auto-committing transaction before processing DDL due to autocommit_before_ddl setting
        
        found:
        NOTICE: auto-committing transaction before processing DDL due to autocommit_before_ddl setting
        NOTICE: auto-committing transaction before processing DDL due to autocommit_before_ddl setting
        NOTICE: auto-committing transaction before processing DDL due to autocommit_before_ddl setting
        NOTICE: auto-committing transaction before processing DDL due to autocommit_before_ddl setting
        pq: restart transaction: TransactionRetryWithProtoRefreshError: TransactionRetryError: retry txn (RETRY_ASYNC_WRITE_FAILURE - missing intent on: /Tenant/10/Table/54/1/1044389136311648257/"legacy_payload"/1914-11-26T02:02:08.400091999Z/0): "sql txn" meta={id=4a52d1e8 key=/Tenant/10/Table/3/1/112/2/1 iso=Serializable pri=0.01657838 epo=0 ts=1738792670.607560510,2 min=1738792670.599908001,0 seq=29} lock=true stat=PENDING rts=1738792670.607560510,2 wto=false gul=1738792671.099908001,0
        HINT: See: https://www.cockroachlabs.com/docs/dev/transaction-retry-error-reference.html#retry_async_write_failure
    testutils.go:302: no Invalid Descriptors
    panic.go:626: -- test log scope end --
test logs left over in: outputs.zip/logTestDataDriven_restore_validation_only183859332
--- FAIL: TestDataDriven_restore_validation_only (4.52s)

Parameters:

  • attempt=1
  • run=1
  • shard=20
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/disaster-recovery

This test on roachdash | Improve this report!

Jira issue: CRDB-47226

@github-actions github-actions bot added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery labels Feb 5, 2025
@rafiss rafiss self-assigned this Feb 6, 2025
@rafiss rafiss added P-1 Issues/test failures with a fix SLA of 1 month T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery labels Feb 6, 2025
@rafiss
Copy link
Collaborator

rafiss commented Feb 6, 2025

similar to #140333; flakiness is fallout from #139871

@celiala
Copy link
Collaborator

celiala commented Feb 6, 2025

seeing this error, when trying to mint release-25.1: #140412

Copy link

blathers-crl bot commented Feb 7, 2025

Based on the specified backports for linked PR #140676, I applied the following new label(s) to this issue: branch-release-25.1. Please adjust the labels as needed to match the branches actually affected by this issue, including adding any known older branches.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-disaster-recovery branch-master Failures and bugs on the master branch. branch-release-25.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-1 Issues/test failures with a fix SLA of 1 month T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants