clusterversion: mint 25.1

[celiala]

This PR:

• mints release-25.1
• bumps version.txt to rc.1

checklist for next time:

• confirm that any outstanding version gates for blockers have merged
• set SystemDatabaseSchemaBootstrapVersion to V25_1
• ./dev test pkg/sql/catalog/bootstrap --rewrite -f TestInitialValuesToString
• bump version.txt to rc.1

Release note: None
Epic: REL-1751
Release justification: release-process change: mints 25.1.

[blathers-crl]

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[cockroach-teamcity]

This change is 

[celiala]

[updated Feb 6, 1:15p PST]

• I'm going to skip this failing test: github.com/cockroachdb/cockroach/pkg/kv/kvserver: TestLeaseQueueShedsOnIOOverload , which maps to kv/kvserver: TestLeaseQueueShedsOnIOOverload failed #139324

---

resolved / no longer errors:

1. pkg/upgrade/upgrademanager/upgrademanager_test: TestPauseMigration (should be fixed by release-25.1: upgrade_manager: fix ListBetweenOverride for some tests #140570)
2. pkg/backup: TestDataDriven_restore_validation_only (same error as backup: TestDataDriven_restore_validation_only failed #140550) (should no longer be an issue )
3. pkg/ccl/testccl/workload/schemachange/schemachange_test: TestWorkload (should be fixed by release-25.1: workload/schemachanger: set session variables on all connections #140598)
4. pkg/upgrade/upgrademanager/upgrademanager_test: TestConcurrentMigrationAttempts -- same error as TestPauseMigration (should be fixed by release-25.1: upgrade_manager: fix ListBetweenOverride for some tests #140570)
5. pkg/ccl/kvccl/kvtenantccl/upgradeccl/upgradeccl_test: TestTenantUpgradeFailure (added patch from clusterversion: mint 25.1 #140412 (comment))
6. github.com/cockroachdb/cockroach/pkg/server: TestJoinVersionGate fixed via #140499
7. github.com/cockroachdb/cockroach/pkg/server: TestClusterVersionUpgrade fixed via #140499
8. pkg/ccl/cloudccl/cloudprivilege failures are the same as pkg/ccl/cloudccl/cloudprivilege/cloudprivilege_test: TestURIRequiresAdminOrPrivilege failed #140524
   • update: these issues are related to networking change (see #db-engineering internal thread : https://cockroachlabs.slack.com/archives/C05B1BPMJLE/p1738785762885549)

https://mesolite.cluster.engflow.com/invocations/default/67888c1f-bbcd-4811-8147-66736ae9313d?treeFilterStatus=failed#targets-Ly9wa2cvY2NsL2Nsb3VkY2NsL2Nsb3VkcHJpdmlsZWdlOmNsb3VkcHJpdmlsZWdlX3Rlc3Q=

[celiala]

test failure 1 [of 4] is because endCV is greater than V25_1:

• cockroach/pkg/upgrade/upgrademanager/manager_external_test.go

  Lines 569 to 570 in 2e7d5a6

  	endCV := clusterversion.Latest + 1
  	startCV := clusterversion.Latest

--- FAIL: TestPauseMigration (0.44s)
    test_log_scope.go:165: test logs captured to: /tmp/cockroach/_tmp/b105ec692cb73561b99946781063daad/logTestPauseMigration2970154246
    test_log_scope.go:76: use -show-logs to present logs inline
    test_server_shim.go:88: cluster virtualization disabled due to issue: #107393 (expected label: C-bug)
    manager_external_test.go:675:
        	Error Trace:	pkg/upgrade/upgrademanager/manager_external_test.go:675
        	Error:      	Received unexpected error:
        	            	pq: internal error: new system schema version (25.1) is lower than previous system schema version (25.1-upgrading-step-002)
        	Test:       	TestPauseMigration
    panic.go:626: -- test log scope end --
FAIL
I250205 05:36:52.082345 1 (gostd) testmain.go:99  [-] 1  Test //pkg/upgrade/upgrademanager:upgrademanager_test exited with error code 1

[celiala]

UPDATE: resolved ✅

test 2 [of 4] TestTenantUpgradeFailure/upgrade_tenant_have_it_crash_then_resume Failure

=== RUN   TestTenantUpgradeFailure/upgrade_tenant_have_it_crash_then_resume
    tenant_upgrade_test.go:468: create a tenant before upgrading anything
    tenant_upgrade_test.go:473: ensure that the tenant works and verify its version
    tenant_upgrade_test.go:489: upgrade the storage cluster to v2
    tenant_upgrade_test.go:492: ensure that the tenant still works
    tenant_upgrade_test.go:495: upgrade the tenant cluster, expecting the upgrade to fail on v1
    tenant_upgrade_test.go:425: v1 migration running
    tenant_upgrade_test.go:496: expected query 'SET CLUSTER SETTING version = $1' to return a non-nil error
    --- FAIL: TestTenantUpgradeFailure/upgrade_tenant_have_it_crash_then_resume (2.39s)

[celiala]

UPDATE: resolved ✅

TestJoinVersionGate and TestClusterVersionUpgrade have the same error, which will be fixed by #140499

[celiala]

@dt @RaduBerinde - I could use your help figuring out why these version-related failures are happening, when I try to mint 25.1 - thank you!

Tests are in these comments:

• clusterversion: mint 25.1 #140412 (comment)
• clusterversion: mint 25.1 #140412 (comment)

[celiala]

UPDATE: resolved ✅

new pkg/ccl/cloudccl/cloudprivilege failures are the same as #140524

[RaduBerinde]

The TestTenantUpgradeFailure failure is fixed by this diff:

--- a/pkg/ccl/kvccl/kvtenantccl/upgradeccl/tenant_upgrade_test.go
+++ b/pkg/ccl/kvccl/kvtenantccl/upgradeccl/tenant_upgrade_test.go
@@ -355,7 +355,7 @@ func TestTenantUpgradeFailure(t *testing.T) {
                        break
                }
        }
-       if v1 == (roachpb.Version{}) {
+       if v1 == (roachpb.Version{}) || v1 == v2 {
                // There is no in-between version supported; skip this test.
                skip.IgnoreLint(t, "test can only run when we support two previous releases")
        }

[RaduBerinde]

Reviewable status: complete! 1 of 0 LGTMs obtained

[celiala]

I'm going to skip this failing test:

• github.com/cockroachdb/cockroach/pkg/kv/kvserver: TestLeaseQueueShedsOnIOOverload
  which maps to kv/kvserver: TestLeaseQueueShedsOnIOOverload failed #139324

Test run details:
https://mesolite.cluster.engflow.com/invocations/default/13e6038b-576a-49a2-9a7f-f87db70e1999?treeFilterStatus=failed&testReportShard=37&testReportAttempt=0#highlights