opt/bench: fix benchmark regression #138740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR cockroachdb#138641 caused extra allocations for plan gist factories in optimizer benchmarks. These allocations should not be included in benchmark results, so they have been eliminated. Release note: None
|
This change is |
|
yuzefovich
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @michae2)
…der` For our purposes in base64-encoding plan gists, using `bytes.Buffer` in `Encoder` causes fewer allocations, presumably because of a more aggressive growth algorithm. Release note: None
|
I added a second commit. Will post benchmark results of that commit shortly. |
yuzefovich
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
👍
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
|
Diff between first and second commit: |
|
TFTR! bors r+ |
|
Build failed (retrying...):
|
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opt/bench: fix benchmark regression
PR #138641 caused extra allocations for plan gist factories in optimizer
benchmarks. These allocations should not be included in benchmark
results, so they have been eliminated.
Release note: None
util/base64: use
bytes.Bufferinstead ofstrings.BuilderinEncoderFor our purposes in base64-encoding plan gists, using
bytes.BufferinEncodercauses fewer allocations, presumably because of a moreaggressive growth algorithm.
Epic: None
Release note: None