Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clusterversion: move to 25.2 version #139387

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

RaduBerinde
Copy link
Member

@RaduBerinde RaduBerinde commented Jan 17, 2025

clusterversion: move to 25.2 version

Checklist:

  • Add version key constant for new release (e.g. V24_2), equal to Latest.
    Note that we do NOT update the PreviousRelease constant. We can only update the
    PreviousRelease when an RC is published, which is needed for upgrade
    roachtests.
  • Add final version for the previous release (e.g. V24_1).
  • Add start version (e.g. V24_2Start with version 24.1-2) and add a new
    first upgrade for it (in upgrades/upgrades.go).
  • Update roachpb.successorSeries map and update TestReleaseSeriesSuccessor
  • Update pkg/build/version.txt to the new version (e.g. v24.2.0-alpha.00000000)
  • Update the scplan rules in pkg/sql/schemachanger/scplan/internal/rules:
    • copy the contents of current into a new release directory for the previous version
      (e.g. release_24_1)
    • change package name in all files (including BUILD.bazel), and update the
      version in current/helpers.go
    • update rulesForReleases in scplan/plan.go
    • rewrite the test outputs: ./dev test pkg/sql/schemachanger/scplan/internal/rules/... --rewrite
    • rewrite TestDeclarativeRules output: ./dev test pkg/cli -f DeclarativeRules --rewrite
  • Update releases file:
    bazel build //pkg/cmd/release:release
    _bazel/bin/pkg/cmd/release/release_/release update-releases-file
    
    Note that the forked release version will disappear from the releases file. This
    is what we want; if it is here, we will attempt to run upgrade tests against it.
  • Regenerate expected test data as needed (usually
    pkg/sql/catalog/systemschema_test and some logictests).

Epic: REL-1746
Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@RaduBerinde RaduBerinde force-pushed the bump-version-25.2 branch 4 times, most recently from 1ac0e56 to 741ebc4 Compare January 18, 2025 21:01
**Checklist**:

- [x] Add version key constant for new release (e.g. `V24_2`), equal to `Latest`.
  Note that we do NOT update the `PreviousRelease` constant. We can only update the
  `PreviousRelease` when an RC is published, which is needed for upgrade
  roachtests.
- [x] Add final version for the previous release (e.g. `V24_1`).
- [x] Add start version (e.g. `V24_2Start` with version `24.1-2`) and add a new
  first upgrade for it (in `upgrades/upgrades.go`).
- [x] Update `roachpb.successorSeries` map and update `TestReleaseSeriesSuccessor`
- [x] Update `pkg/build/version.txt` to the new version (e.g. `v24.2.0-alpha.00000000`)
- [x] Update the `scplan` rules in `pkg/sql/schemachanger/scplan/internal/rules`:
  - copy the contents of `current` into a new release directory for the previous version
    (e.g. `release_24_1`)
  - change package name in all files (including `BUILD.bazel`), and update the
    version in `current/helpers.go`
  - update `rulesForReleases` in `scplan/plan.go`
  - rewrite the test outputs: `./dev test pkg/sql/schemachanger/scplan/internal/rules/... --rewrite`
  - rewrite `TestDeclarativeRules` output: `./dev test pkg/cli -f DeclarativeRules --rewrite`
- [x] Update releases file:
  ```
  bazel build //pkg/cmd/release:release
  _bazel/bin/pkg/cmd/release/release_/release update-releases-file
  ```
  Note that the forked release version will disappear from the releases file. This
  is what we want; if it is here, we will attempt to run upgrade tests against it.
- [x] Regenerate expected test data as needed (usually
  `pkg/sql/catalog/systemschema_test` and some logictests).

Epic: REL-1746
Release note: None
@RaduBerinde RaduBerinde marked this pull request as ready for review January 19, 2025 16:20
@RaduBerinde RaduBerinde requested review from a team as code owners January 19, 2025 16:20
@RaduBerinde RaduBerinde requested review from srosenberg, golgeek, rail and celiala and removed request for a team January 19, 2025 16:20
@RaduBerinde
Copy link
Member Author

TFTR!

bors r+

@craig craig bot merged commit 6c80490 into cockroachdb:master Jan 22, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants