build: upgrade to go 1.23.6 #140626
Draft
build: upgrade to go 1.23.6 #140626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rickystewart
force-pushed
the
go1-23-6-upgrade
branch
6 times, most recently
from
23adea6 to
95dd554
Compare
rickystewart
changed the title
rickystewart
force-pushed
the
go1-23-6-upgrade
branch
2 times, most recently
from
8d9acb6 to
8c500bb
Compare
* [ ] Adjust the Pebble tests to run in new version. * [ ] Update [our `go` fork](https://github.com/cockroachdb/go) with a new branch containing our patches. Create a new branch `cockroach-go$GO_VERSION` and take note of the commit ID. * [ ] Update `build/teamcity/internal/release/build-and-publish-patched-go/commit.txt` with the commit ID in the `go` fork. * [ ] Update `build/teamcity/internal/release/build-and-publish-patched-go/impl.sh` with the new `GOVERS` and adjust SHA256 sums as necessary. * [ ] Adjust `GO_FIPS_COMMIT` for the FIPS Go toolchain ([source](./teamcity/internal/release/build-and-publish-patched-go/impl-fips.sh)). * [ ] Run the `Internal / Cockroach / Build / Toolchains / Publish Patched Go for Mac` build configuration in TeamCity with your latest version of the script above. Note the job depends on another job `Build and Publish Patched Go`. That job prints out the SHA256 of all tarballs, which you will need to copy-paste into `WORKSPACE` (see below). `Publish Patched Go for Mac` is an extra step that publishes the *signed* `go` binaries for macOS. That job also prints out the SHA256 of the Mac tarballs in particular. * [ ] Adjust `--@io_bazel_rules_go//go/toolchain:sdk_version` in [.bazelrc](../.bazelrc). * [ ] Bump the version in `WORKSPACE` under `go_download_sdk`. You may need to bump [rules_go](https://github.com/bazelbuild/rules_go/releases). Also edit the filenames listed in `sdks` and update all the hashes to match what you built in the step above. * [ ] Bump the version in `WORKSPACE` under `go_download_sdk` for the FIPS version of Go (`go_sdk_fips`). * [ ] Run `./dev generate bazel` to refresh `distdir_files.bzl`, then `bazel fetch @distdir//:archives` to ensure you've updated all hashes to the correct value. * [ ] Bump the go version in `go.mod`. * [ ] Bump the default installed version of Go in `bootstrap-debian.sh` ([source](./bootstrap/bootstrap-debian.sh)). * [ ] Replace other mentions of the older version of go (grep for `golang:<old_version>` and `go<old_version>`). Epic: CRDB-41921 Release note (build change): Upgrade to Go 1.23.6
rickystewart
force-pushed
the
go1-23-6-upgrade
branch
from
8c500bb to
ff86e43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gofork with a new branch containing our patches. Create a new branchcockroach-go$GO_VERSIONand take note of the commit ID.build/teamcity/internal/release/build-and-publish-patched-go/commit.txtwith the commit ID in thegofork.build/teamcity/internal/release/build-and-publish-patched-go/impl.shwith the newGOVERSand adjust SHA256 sums as necessary.GO_FIPS_COMMITfor the FIPS Go toolchain (source).Internal / Cockroach / Build / Toolchains / Publish Patched Go for Macbuild configuration in TeamCity with your latest version of the script above. Note the job depends on another jobBuild and Publish Patched Go. That job prints out the SHA256 of all tarballs, which you will need to copy-paste intoWORKSPACE(see below).Publish Patched Go for Macis an extra step that publishes the signedgobinaries for macOS. That job also prints out the SHA256 of the Mac tarballs in particular.--@io_bazel_rules_go//go/toolchain:sdk_versionin .bazelrc.WORKSPACEundergo_download_sdk. You may need to bump rules_go. Also edit the filenames listed insdksand update all the hashes to match what you built in the step above.WORKSPACEundergo_download_sdkfor the FIPS version of Go (go_sdk_fips)../dev generate bazelto refreshdistdir_files.bzl, thenbazel fetch @distdir//:archivesto ensure you've updated all hashes to the correct value.go.mod.bootstrap-debian.sh(source).golang:<old_version>andgo<old_version>).Epic: CRDB-41921
Release note (build change): Upgrade to Go 1.23.6