go_binary: fix pgoprofile default
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rail
approved these changes
Jan 14, 2025
rickystewart
added a commit
to rickystewart/cockroach
that referenced
this pull request
Jan 14, 2025
To pull in cockroachdb/rules_go#24 Epic: CRDB-41952 Release note: None
rickystewart
added a commit
to rickystewart/cockroach
that referenced
this pull request
Jan 14, 2025
To pull in cockroachdb/rules_go#24 Epic: CRDB-41952 Release note: None
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Jan 14, 2025
138873: cloudtestutils: refactor CheckExportStore, CheckListFiles, CheckNoPermissions r=RaduBerinde a=RaduBerinde This PR is taking a first step towards removing `ExternalIODir` from `cluster.Settings`. #### cloudtestutils: refactor CheckExportStore This change adds a `cloudtestutils.StoreInfo` structure and refactors `CheckExportStore` to use it, making the call sites simpler and more readable. We now pass the external IO dir explicitly through `StoreInfo` instead of getting it from the settings. Epic: none Release note: None #### cloudtestutils: refactor CheckListFiles Refactor `CheckListFiles` and `CheckListFilesCanonical` to use `StoreInfo`. Epic: none Release note: None #### cloudtestutils: refactor CheckNoPermissions Use `StoreInfo` for `CheckNoPermissions.` Epic: none Release note: None 139044: build: update `rules_go` r=jlinder a=rickystewart To pull in cockroachdb/rules_go#24 Epic: CRDB-41952 Release note: None Co-authored-by: Radu Berinde <[email protected]> Co-authored-by: Ricky Stewart <[email protected]>
InManuBytes
pushed a commit
to InManuBytes/cockroach
that referenced
this pull request
Jan 15, 2025
To pull in cockroachdb/rules_go#24 Epic: CRDB-41952 Release note: None
mohini-crl
pushed a commit
to mohini-crl/cockroach
that referenced
this pull request
Jan 17, 2025
To pull in cockroachdb/rules_go#24 Epic: CRDB-41952 Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bazel-contrib#4226.