Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polar to list of supported languages #40

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

vkarpov15
Copy link
Contributor

Hi,

Oso makes heavy use of codehike in their Oso Cloud docs, but right now they have to use ruby highlighting as a substitute for Polar, which is their language for modeling authorization rules. I got Polar syntax highlighting working with a slightly hacky postinstall script, but it would be very helpful if codehike could support Polar syntax highlighting natively.

The polar.tmLanguage.json in this PR is copied from this repo: https://github.com/osohq/polar-grammar

Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lighter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2024 0:14am

@pomber
Copy link
Contributor

pomber commented Jul 12, 2024

hey

I will start using the grammars from https://github.com/shikijs/textmate-grammars-themes, maybe you can add it there.

I'll also add the option for custom grammars in codehike v1

@vkarpov15
Copy link
Contributor Author

Is there any way you can merge this in the v0.x release series? Custom grammars will be great when they're released and I'll switch to using that, but this change would be helpful for us in the interim.

@pomber pomber merged commit ab54b55 into code-hike:main Jul 13, 2024
2 checks passed
@vkarpov15
Copy link
Contributor Author

Thank you very much 🫶

@pomber
Copy link
Contributor

pomber commented Jul 13, 2024

there wont be a new release for @code-hike/mdx, but you can probably force the new version of @code-hike/lighter

@pomber
Copy link
Contributor

pomber commented Jul 13, 2024

or migrate to codehike v1, but that's more work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants