Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: admin can add hr #546

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: admin can add hr #546

wants to merge 6 commits into from

Conversation

devsharmagit
Copy link
Contributor

closes #521

here is a video showcase

ccccccccc.mp4

@devsharmagit
Copy link
Contributor Author

@VineeTagarwaL-code
I tried to solve admin can add HR issue.

@VineeTagarwaL-code
Copy link
Collaborator

Nice

@VineeTagarwaL-code
Copy link
Collaborator

reviewing the code and merging

@VineeTagarwaL-code
Copy link
Collaborator

will test out locally once to make sure everything is good !

@VineeTagarwaL-code
Copy link
Collaborator

fix conflicts will merge

@devsharmagit
Copy link
Contributor Author

@VineeTagarwaL-code
fixed conflicts and build

@VineeTagarwaL-code
Copy link
Collaborator

checking and merging if everything feels fine

@VineeTagarwaL-code
Copy link
Collaborator

Broken -

  1. add validation error properly
  2. generated password doesnt matches and throws incorrect email or password error
  3. make the font size little bigger for bigger desktop

@devsharmagit
Copy link
Contributor Author

@VineeTagarwaL-code
done the requested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VineeTagarwaL-code VineeTagarwaL-code VineeTagarwaL-code approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: admin can add hr feature
2 participants
@devsharmagit @VineeTagarwaL-code