Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added skeleton ui for appbar when status is loading #188

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Bhushan-04
Copy link

@Bhushan-04 Bhushan-04 commented Sep 20, 2024


Pull Request Title

Thank you for contributing to our project! Please provide a summary of your changes and reference any related issues below.

Issue Number: Fixes #172

🛠️ Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 🚨 Breaking change
  • 📚 Documentation update

✅ Checklist

To ensure a smooth review process, please check off each item as you complete it:

  • [*] Code Style: My code adheres to the project’s style guidelines.
  • [*] Self-Review: I have reviewed my own code and made improvements.
  • Comments: I’ve added comments to explain complex or non-obvious parts of the code.
  • Documentation: I’ve updated the documentation to reflect my changes.
  • Warnings: My changes introduce no new warnings.
  • Tests: I’ve added tests to verify that my changes work as expected.
  • Passes Locally: All new and existing unit tests pass on my local machine.

We appreciate your contributions! If you have any questions or need further assistance, feel free to reach out.

fix :
problem : Session is picked up after the page fully loads and therefore leading to a delay in the rendering of user image and wallet icon

Solution : Added Skeleton when status is loading to avoid delay in rendering of image and wallet icon

Before :
https://github.com/user-attachments/assets/df6063a2-4ddf-4a5f-a25c-4e462bef6b64

After:
When User is not logged in-
https://github.com/user-attachments/assets/d84e105b-f059-4b4d-889c-31ee660d4920

When User is logged in-
https://github.com/user-attachments/assets/6d0b674e-bbca-42b3-a30d-e8bbb89e3b14

@Ameerjafar
Copy link
Contributor

@cb7chaitanya what about this pr.

@cb7chaitanya
Copy link
Collaborator

What about it? @Ameerjafar
I am not going to merge it @Bhushan-04 as the issue was assigned to @Ameerjafar and I can only merge it if @Ameerjafar is not going to turn up with a PR

@Ameerjafar
Copy link
Contributor

Ameerjafar commented Sep 20, 2024 via email

@Bhushan-04
Copy link
Author

What about it? @Ameerjafar I am not going to merge it @Bhushan-04 as the issue was assigned to @Ameerjafar and I can only merge it if @Ameerjafar is not going to turn up with a PR

Sure , no problem sir !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Appbar rendering issue
3 participants