Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configured dark theme for wallet page #224

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jassBawa
Copy link

@jassBawa jassBawa commented Oct 19, 2024


Pull Request Title

This PR adds darkmode support to wallet page. Also improving the UI with simple and minimal animations.

Issue Number: Fixes #220 (issue number)

🛠️ Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 🚨 Breaking change
  • 📚 Documentation update

✅ Checklist

To ensure a smooth review process, please check off each item as you complete it:

  • Code Style: My code adheres to the project’s style guidelines.
  • Self-Review: I have reviewed my own code and made improvements.
  • Comments: I’ve added comments to explain complex or non-obvious parts of the code.
  • Documentation: I’ve updated the documentation to reflect my changes.
  • Warnings: My changes introduce no new warnings.
  • Tests: I’ve added tests to verify that my changes work as expected.
  • Passes Locally: All new and existing unit tests pass on my local machine.

Here is the video for ui reference

Tiplink-review.vide.mp4

@jassBawa
Copy link
Author

@cb7chaitanya @Rudra-Sankha-Sinhamahapatra will you please review this pr.

The question that may arise for layout file is that i have removed duplicate lines and added themeprovider to it

@Rudra-Sankha-Sinhamahapatra
Copy link
Contributor

Rudra-Sankha-Sinhamahapatra commented Oct 20, 2024

Already someone was working on the issue
He has already raised a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Configure dark mode for pages other than the landing page
3 participants