Pvc pipeline fixes

.github/workflows/lint-test.yaml

@@ -46,5 +46,6 @@ jobs:
           helm repo add kedacore https://kedacore.github.io/charts
           helm repo update
           helm install keda kedacore/keda
+          kubectl apply -f ci/pv.yaml
           ct install --config ct.yaml
         if: steps.list-changed.outputs.changed == 'true'

README.md

@@ -26,6 +26,21 @@ $ helm repo add codecademy https://codecademy-engineering.github.io/helm-charts
 
 You can then run `helm search repo codecademy` to see the charts.
 
+## Tests
+You can test the charts locally using a [Kind](https://kind.sigs.k8s.io/) cluster and [chart testing](https://github.com/helm/chart-testing).
+
+Once you've installed both you can run the following commands to test:
+```
+kind create cluster
+kubectl apply -f charts/service/ci/pv.yaml
+
+helm repo add kedacore https://kedacore.github.io/charts
+helm repo update
+helm install keda kedacore/keda
+
+ct install --config ct.yaml
+```
+
 ## Contribution Guidelines
 
 We'd love to have you contribute! Please refer to our [contribution guidelines](CONTRIBUTING.md) for details.

charts/service/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 name: service
 description: A generic k8s service chart
 type: application
-version: 1.7.5
+version: 1.7.6
 maintainers:
   - email: [email protected]
     name: devops

charts/service/ci/custom-values.yaml

@@ -98,10 +98,19 @@ hostAliases:
       - anotherhost.com
       - anotherhost2.com
 
-persistentVolumeClaim:
-  - claimName: test-efs
+volumeMounts:
+  - name: test-pv
+    mountPath: /tmp/
+
+volumes:
+  - name: test-pv
+    persistentVolumeClaim:
+      claimName: test-pvc
+
+persistentVolumeClaims:
+  - claimName: test-pvc
     storageClass:
       accessModes:
-        - ReadWriteMany
-      name: efs
+        - ReadWriteOnce
+      name: standard
     storage: 1Gi

charts/service/templates/pvc.yaml

@@ -3,7 +3,7 @@
 apiVersion: v1
 kind: PersistentVolumeClaim
 metadata:
-  name: {{ .persistentVolumeClaim.claimName }}
+  name: {{ .claimName }}
 spec:
   accessModes: {{ .storageClass.accessModes }}
   storageClassName: {{ .storageClass.name }}

ci/pv.yaml

@@ -0,0 +1,15 @@
+# Create a persistent volume to test PVCs in CI
+apiVersion: v1
+kind: PersistentVolume
+metadata:
+  name: test-pv
+  labels:
+    type: standard
+spec:
+  storageClassName: standard
+  capacity:
+    storage: 1Gi
+  accessModes:
+    - ReadWriteOnce
+  hostPath:
+    path: "/tmp/"