-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump to eslint9+ and remove eslint-config-google #1591
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1591 +/- ##
==========================================
+ Coverage 91.94% 93.13% +1.19%
==========================================
Files 5 5
Lines 335 335
Branches 78 78
==========================================
+ Hits 308 312 +4
+ Misses 27 23 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Was working on #1524 and noticed that all the formatting rules were gone. Was that intentional, or did you forget to migrate to eslint-stylistic? |
@lishaduck I wish I had known this so much earlier, thanks for all the info! That said, we are moving to a bash script in the next release and thus the js/ts stuff will be all going away. Let me know if that makes sense. |
Yay! Dropping Node is always good 🙃 I assume it's to speed it up more, but may I request that you fix #770/#1582 while you're at it b/c (if quoted right) it should just expand with native bash globs, right? |
@lishaduck ahhh, yes I'll add that to the priority list post release next week |
No description provided.