chore: Tidy up virtual renderers #3353

nicholas-codecov · 2024-10-04T17:35:35Z

Description

This PR tidy's up the virtual renderers by extracting some of their more specific logic out into their own hooks so that they can be shared between the two components rather than having it be duplicated.

Notable Changes

Create useDisablePointerEvents, useLeftScrollSync, useSyncScrollMargin, and useSyncWrapperWidth hooks
Update virtual renderers to use the new hooks

codecov · 2024-10-04T17:38:14Z

Bundle Report

Changes will decrease total bundle size by 1.38kB (-0.02%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-production-array-push	6.14MB	1.38kB (-0.02%) ⬇️

codecov-qa · 2024-10-04T17:38:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (1c3aee8) to head (d4a75db).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3353      +/-   ##
==========================================
- Coverage   99.17%   99.17%   -0.01%     
==========================================
  Files         805      809       +4     
  Lines       14255    14209      -46     
  Branches     3930     3921       -9     
==========================================
- Hits        14138    14092      -46     
  Misses        108      108              
  Partials        9        9

Files with missing lines	Coverage Δ
...hangedTab/shared/CommitFileDiff/CommitFileDiff.jsx	`100.00% <ø> (ø)`
...rectChangesTable/CommitFileDiff/CommitFileDiff.jsx	`100.00% <ø> (ø)`
...FilesChangedTab/FilesChanged/FileDiff/FileDiff.jsx	`97.22% <ø> (ø)`
...ge/routes/IndirectChangesTab/FileDiff/FileDiff.jsx	`97.22% <ø> (ø)`
src/shared/RawFileViewer/RawFileViewer.tsx	`100.00% <ø> (ø)`
...useDisablePointerEvents/useDisablePointerEvents.ts	`100.00% <100.00%> (ø)`
src/ui/VirtualRenderers/ColorBar.tsx	`100.00% <ø> (ø)`
src/ui/VirtualRenderers/LineNumber.tsx	`100.00% <ø> (ø)`
src/ui/VirtualRenderers/VirtualDiffRenderer.tsx	`98.83% <100.00%> (ø)`
src/ui/VirtualRenderers/VirtualFileRenderer.tsx	`98.00% <100.00%> (ø)`
... and 4 more

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.93% <ø> (ø)`
Services	`99.45% <ø> (ø)`
Shared	`99.80% <100.00%> (+<0.01%)`	⬆️
UI	`99.06% <100.00%> (-0.05%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c3aee8...d4a75db. Read the comment docs.

codecov · 2024-10-04T17:39:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (1c3aee8) to head (d4a75db).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3353      +/-   ##
==========================================
- Coverage   99.17%   99.17%   -0.01%     
==========================================
  Files         805      809       +4     
  Lines       14255    14209      -46     
  Branches     3930     3916      -14     
==========================================
- Hits        14138    14092      -46     
  Misses        108      108              
  Partials        9        9

Files with missing lines	Coverage Δ
...hangedTab/shared/CommitFileDiff/CommitFileDiff.jsx	`100.00% <ø> (ø)`
...rectChangesTable/CommitFileDiff/CommitFileDiff.jsx	`100.00% <ø> (ø)`
...FilesChangedTab/FilesChanged/FileDiff/FileDiff.jsx	`97.22% <ø> (ø)`
...ge/routes/IndirectChangesTab/FileDiff/FileDiff.jsx	`97.22% <ø> (ø)`
src/shared/RawFileViewer/RawFileViewer.tsx	`100.00% <ø> (ø)`
...useDisablePointerEvents/useDisablePointerEvents.ts	`100.00% <100.00%> (ø)`
src/ui/VirtualRenderers/ColorBar.tsx	`100.00% <ø> (ø)`
src/ui/VirtualRenderers/LineNumber.tsx	`100.00% <ø> (ø)`
src/ui/VirtualRenderers/VirtualDiffRenderer.tsx	`98.83% <100.00%> (ø)`
src/ui/VirtualRenderers/VirtualFileRenderer.tsx	`98.00% <100.00%> (ø)`
... and 4 more

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.93% <ø> (ø)`
Services	`99.45% <ø> (ø)`
Shared	`99.80% <100.00%> (+<0.01%)`	⬆️
UI	`99.06% <100.00%> (-0.05%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c3aee8...d4a75db. Read the comment docs.

codecov-public-qa · 2024-10-04T17:39:29Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (1c3aee8) to head (d4a75db).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3353      +/-   ##
==========================================
- Coverage   99.17%   99.17%   -0.01%     
==========================================
  Files         805      809       +4     
  Lines       14255    14209      -46     
  Branches     3935     3916      -19     
==========================================
- Hits        14138    14092      -46     
  Misses        108      108              
  Partials        9        9

Files	Coverage Δ
...hangedTab/shared/CommitFileDiff/CommitFileDiff.jsx	`100.00% <ø> (ø)`
...rectChangesTable/CommitFileDiff/CommitFileDiff.jsx	`100.00% <ø> (ø)`
...FilesChangedTab/FilesChanged/FileDiff/FileDiff.jsx	`97.22% <ø> (ø)`
...ge/routes/IndirectChangesTab/FileDiff/FileDiff.jsx	`97.22% <ø> (ø)`
src/shared/RawFileViewer/RawFileViewer.tsx	`100.00% <ø> (ø)`
...useDisablePointerEvents/useDisablePointerEvents.ts	`100.00% <100.00%> (ø)`
src/ui/VirtualRenderers/ColorBar.tsx	`100.00% <ø> (ø)`
src/ui/VirtualRenderers/LineNumber.tsx	`100.00% <ø> (ø)`
src/ui/VirtualRenderers/VirtualDiffRenderer.tsx	`98.83% <100.00%> (ø)`
src/ui/VirtualRenderers/VirtualFileRenderer.tsx	`98.00% <100.00%> (ø)`
... and 4 more

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.93% <ø> (ø)`
Services	`99.45% <ø> (ø)`
Shared	`99.80% <100.00%> (+<0.01%)`	⬆️
UI	`99.06% <100.00%> (-0.05%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c3aee8...d4a75db. Read the comment docs.

codecov-releaser · 2024-10-04T17:42:47Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`525a243`	Fri, 04 Oct 2024 17:42:47 GMT	Expired	Expired
`71fe3e1`	Fri, 04 Oct 2024 18:00:22 GMT	Expired	Expired
`2063cac`	Wed, 16 Oct 2024 15:55:44 GMT	Expired	Expired
`d4a75db`	Wed, 16 Oct 2024 16:45:28 GMT	Cloud	Enterprise

codecov-staging · 2024-10-04T17:56:40Z

Bundle Report

Changes will decrease total bundle size by 11.29kB (-0.18%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-staging-array-push	6.14MB	11.29kB (-0.18%) ⬇️

codecov-notifications · 2024-10-04T17:57:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main    #3353      +/-   ##
==========================================
- Coverage   99.17%   99.17%   -0.01%     
==========================================
  Files         805      809       +4     
  Lines       14255    14209      -46     
  Branches     3930     3916      -14     
==========================================
- Hits        14138    14092      -46     
  Misses        108      108              
  Partials        9        9

Files with missing lines	Coverage Δ
...hangedTab/shared/CommitFileDiff/CommitFileDiff.jsx	`100.00% <ø> (ø)`
...rectChangesTable/CommitFileDiff/CommitFileDiff.jsx	`100.00% <ø> (ø)`
...FilesChangedTab/FilesChanged/FileDiff/FileDiff.jsx	`97.22% <ø> (ø)`
...ge/routes/IndirectChangesTab/FileDiff/FileDiff.jsx	`97.22% <ø> (ø)`
src/shared/RawFileViewer/RawFileViewer.tsx	`100.00% <ø> (ø)`
...useDisablePointerEvents/useDisablePointerEvents.ts	`100.00% <100.00%> (ø)`
src/ui/VirtualRenderers/ColorBar.tsx	`100.00% <ø> (ø)`
src/ui/VirtualRenderers/LineNumber.tsx	`100.00% <ø> (ø)`
src/ui/VirtualRenderers/VirtualDiffRenderer.tsx	`98.83% <100.00%> (ø)`
src/ui/VirtualRenderers/VirtualFileRenderer.tsx	`98.00% <100.00%> (ø)`
... and 4 more

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.93% <ø> (ø)`
Services	`99.45% <ø> (ø)`
Shared	`99.80% <100.00%> (+<0.01%)`	⬆️
UI	`99.06% <100.00%> (-0.05%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c3aee8...d4a75db. Read the comment docs.

suejung-sentry approved these changes Oct 16, 2024

View reviewed changes

nicholas-codecov added 8 commits October 16, 2024 13:34

rename directory

6481679

pull out pointer events disable to their own shared util

57f63c5

move the left scrolling sync logic into it's own hook

113c63b

move the syncing scroll margin logic to it's own hook

03cb958

move wrapper width syncing to it's own hook

c51ed68

remove logic from renderers and utilize the new util hooks

1081348

add in explicit tests for these new hooks

c37f35e

fix import issue

1d0442f

nicholas-codecov force-pushed the chore-tidy-up-virtual-renderers branch from 2063cac to 1d0442f Compare October 16, 2024 16:34

fix up imports

d4a75db

nicholas-codecov added this pull request to the merge queue Oct 16, 2024

Merged via the queue into main with commit 1b2bf9f Oct 16, 2024
62 checks passed

nicholas-codecov deleted the chore-tidy-up-virtual-renderers branch October 16, 2024 17:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Tidy up virtual renderers #3353

chore: Tidy up virtual renderers #3353

nicholas-codecov commented Oct 4, 2024

codecov bot commented Oct 4, 2024 •

edited

Loading

codecov-qa bot commented Oct 4, 2024 •

edited

Loading

codecov bot commented Oct 4, 2024 •

edited

Loading

codecov-public-qa bot commented Oct 4, 2024 •

edited

Loading

codecov-releaser commented Oct 4, 2024 •

edited

Loading

codecov-staging bot commented Oct 4, 2024 •

edited

Loading

codecov-notifications bot commented Oct 4, 2024 •

edited

Loading

chore: Tidy up virtual renderers #3353

chore: Tidy up virtual renderers #3353

Conversation

nicholas-codecov commented Oct 4, 2024

Description

Notable Changes

codecov bot commented Oct 4, 2024 • edited Loading

Bundle Report

codecov-qa bot commented Oct 4, 2024 • edited Loading

Codecov Report

codecov bot commented Oct 4, 2024 • edited Loading

Codecov Report

codecov-public-qa bot commented Oct 4, 2024 • edited Loading

Codecov Report

codecov-releaser commented Oct 4, 2024 • edited Loading

✅ Deploy preview for gazebo ready!

codecov-staging bot commented Oct 4, 2024 • edited Loading

Bundle Report

codecov-notifications bot commented Oct 4, 2024 • edited Loading

Codecov Report

codecov bot commented Oct 4, 2024 •

edited

Loading

codecov-qa bot commented Oct 4, 2024 •

edited

Loading

codecov bot commented Oct 4, 2024 •

edited

Loading

codecov-public-qa bot commented Oct 4, 2024 •

edited

Loading

codecov-releaser commented Oct 4, 2024 •

edited

Loading

codecov-staging bot commented Oct 4, 2024 •

edited

Loading

codecov-notifications bot commented Oct 4, 2024 •

edited

Loading