feat: Set token required in Tokenless section under org upload token #3366

RulaKhaled · 2024-10-08T19:03:16Z

Description

Hook up API work with tokenless section under org upload token tab.

depends on:

feat: Tokenless banners #3358

Notable Changes

New mutation hook
Hook up api work with section
A lot of tests

Screenshots

Nothing visual changed, notification on a successful mutation is sent:

Screen.Recording.2024-10-09.at.10.53.25.AM.mov

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

codecov-staging · 2024-10-08T19:06:06Z

Bundle Report

Changes will increase total bundle size by 2.95kB (0.05%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-staging-array-push	6.13MB	2.95kB (0.05%) ⬆️

codecov · 2024-10-08T19:06:29Z

Bundle Report

Changes will increase total bundle size by 2.95kB (0.05%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-production-array-push	6.13MB	2.95kB (0.05%) ⬆️

codecov-qa · 2024-10-08T19:06:58Z

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.16%. Comparing base (292f404) to head (967a5be).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ken/TokenlessSection/useSetUploadTokenRequired.tsx	89.47%	2 Missing ⚠️

@@            Coverage Diff             @@
##             main    #3366      +/-   ##
==========================================
- Coverage   99.17%   99.16%   -0.02%     
==========================================
  Files         802      804       +2     
  Lines       14139    14185      +46     
  Branches     3896     3911      +15     
==========================================
+ Hits        14022    14066      +44     
- Misses        108      110       +2     
  Partials        9        9

Files with missing lines	Coverage Δ
...ploadToken/TokenlessSection/TokenRequiredModal.tsx	`100.00% <100.00%> (ø)`
...gUploadToken/TokenlessSection/TokenlessSection.tsx	`100.00% <100.00%> (ø)`
...rvices/navigation/useNavLinks/useStaticNavLinks.js	`98.80% <100.00%> (+0.01%)`	⬆️
...ken/TokenlessSection/useSetUploadTokenRequired.tsx	`89.47% <89.47%> (ø)`

... and 3 files with indirect coverage changes

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.93% <94.73%> (-0.02%)`	⬇️
Services	`99.45% <100.00%> (+<0.01%)`	⬆️
Shared	`99.80% <ø> (ø)`
UI	`99.10% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 292f404...967a5be. Read the comment docs.

codecov-public-qa · 2024-10-08T19:07:02Z

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.16%. Comparing base (292f404) to head (967a5be).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3366      +/-   ##
==========================================
- Coverage   99.17%   99.16%   -0.02%     
==========================================
  Files         802      804       +2     
  Lines       14139    14185      +46     
  Branches     3901     3911      +10     
==========================================
+ Hits        14022    14066      +44     
- Misses        108      110       +2     
  Partials        9        9

Files	Coverage Δ
...ploadToken/TokenlessSection/TokenRequiredModal.tsx	`100.00% <100.00%> (ø)`
...gUploadToken/TokenlessSection/TokenlessSection.tsx	`100.00% <100.00%> (ø)`
...rvices/navigation/useNavLinks/useStaticNavLinks.js	`98.80% <100.00%> (+0.01%)`	⬆️
...ken/TokenlessSection/useSetUploadTokenRequired.tsx	`89.47% <89.47%> (ø)`

... and 3 files with indirect coverage changes

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.93% <94.73%> (-0.02%)`	⬇️
Services	`99.45% <100.00%> (+<0.01%)`	⬆️
Shared	`99.80% <ø> (ø)`
UI	`99.10% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 292f404...967a5be. Read the comment docs.

codecov-notifications · 2024-10-08T19:07:06Z

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...ken/TokenlessSection/useSetUploadTokenRequired.tsx	89.47%	2 Missing ⚠️

@@            Coverage Diff             @@
##             main    #3366      +/-   ##
==========================================
- Coverage   99.17%   99.16%   -0.02%     
==========================================
  Files         802      804       +2     
  Lines       14139    14185      +46     
  Branches     3901     3911      +10     
==========================================
+ Hits        14022    14066      +44     
- Misses        108      110       +2     
  Partials        9        9

Files with missing lines	Coverage Δ
...ploadToken/TokenlessSection/TokenRequiredModal.tsx	`100.00% <100.00%> (ø)`
...gUploadToken/TokenlessSection/TokenlessSection.tsx	`100.00% <100.00%> (ø)`
...rvices/navigation/useNavLinks/useStaticNavLinks.js	`98.80% <100.00%> (+0.01%)`	⬆️
...ken/TokenlessSection/useSetUploadTokenRequired.tsx	`89.47% <89.47%> (ø)`

... and 3 files with indirect coverage changes

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.93% <94.73%> (-0.02%)`	⬇️
Services	`99.45% <100.00%> (+<0.01%)`	⬆️
Shared	`99.80% <ø> (ø)`
UI	`99.10% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 292f404...967a5be. Read the comment docs.

codecov · 2024-10-09T08:49:29Z

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.16%. Comparing base (292f404) to head (967a5be).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ken/TokenlessSection/useSetUploadTokenRequired.tsx	89.47%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3366      +/-   ##
==========================================
- Coverage   99.17%   99.16%   -0.02%     
==========================================
  Files         802      804       +2     
  Lines       14139    14185      +46     
  Branches     3901     3906       +5     
==========================================
+ Hits        14022    14066      +44     
- Misses        108      110       +2     
  Partials        9        9

Files with missing lines	Coverage Δ
...ploadToken/TokenlessSection/TokenRequiredModal.tsx	`100.00% <100.00%> (ø)`
...gUploadToken/TokenlessSection/TokenlessSection.tsx	`100.00% <100.00%> (ø)`
...rvices/navigation/useNavLinks/useStaticNavLinks.js	`98.80% <100.00%> (+0.01%)`	⬆️
...ken/TokenlessSection/useSetUploadTokenRequired.tsx	`89.47% <89.47%> (ø)`

... and 3 files with indirect coverage changes

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.93% <94.73%> (-0.02%)`	⬇️
Services	`99.45% <100.00%> (+<0.01%)`	⬆️
Shared	`99.80% <ø> (ø)`
UI	`99.10% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 292f404...967a5be. Read the comment docs.

codecov-releaser · 2024-10-09T08:57:10Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`326a561`	Wed, 09 Oct 2024 08:57:10 GMT	Expired	Expired
`625dc4a`	Wed, 09 Oct 2024 09:24:50 GMT	Expired	Expired
`d78982f`	Wed, 09 Oct 2024 09:38:38 GMT	Expired	Expired
`d44f87d`	Wed, 09 Oct 2024 10:35:34 GMT	Expired	Expired
`967a5be`	Thu, 10 Oct 2024 03:44:56 GMT	Cloud	Enterprise

ajay-sentry · 2024-10-09T21:08:54Z

src/pages/AccountSettings/tabs/OrgUploadToken/TokenlessSection/TokenlessSection.test.tsx

+  }
+})
+
+const mockedUseFlags = useFlags as jest.Mock


I think we may need to swap these to vi.mock() similar to this

gazebo/src/pages/AnalyticsPage/Tabs/Tabs.test.tsx

Lines 21 to 22 in 01a7a7c

})

ajay-sentry · 2024-10-09T21:11:41Z

src/pages/AccountSettings/tabs/OrgUploadToken/TokenlessSection/TokenlessSection.tsx

+    if (
+      !isUploadTokenRequiredLoading &&
+      uploadTokenRequiredData &&
+      uploadTokenRequiredData?.uploadTokenRequired !== null


nit: if we're checking for uploadTokenRequiredData I think we don't need the ? on uploadTokenRequiredData?.uploadTokenRequired

TS is weird, this actually tests if it's set to boolean, if i just do uploadTokenRequiredData?.uploadTokenRequired !== null and set it to uploadTokenRequiredData?.uploadTokenRequired it complains about a nullable value:

ajay-sentry · 2024-10-09T21:16:04Z

src/pages/AccountSettings/tabs/OrgUploadToken/TokenlessSection/useSetUploadTokenRequired.tsx

+        })
+      }
+    },
+    onError: () => {


weird how it says this line is uncovered when you specifically have a test for it 🤔

I KNOW RIGHT

i have some feedback for codecov..

ajay-sentry

couple small comments but nothing blocking

RulaKhaled added 5 commits October 6, 2024 15:02

add token required banner

54e9fb1

last tweaks

6b93370

add one more test

bf9629f

add one more test

7508c43

Update with queries, add more tests

f07ad7f

Merge branch 'main' into set-tokenless-changes

326a561

RulaKhaled added 3 commits October 9, 2024 11:18

finalize hook tests

625dc4a

adjust type

d78982f

update with mocked notitifcation fn

d44f87d

RulaKhaled marked this pull request as ready for review October 9, 2024 16:22

ajay-sentry reviewed Oct 9, 2024

View reviewed changes

ajay-sentry approved these changes Oct 9, 2024

View reviewed changes

Update tests to use mocks

967a5be

RulaKhaled added this pull request to the merge queue Oct 11, 2024

Merged via the queue into main with commit f3dbf03 Oct 11, 2024
49 of 62 checks passed

RulaKhaled deleted the set-tokenless-changes branch October 11, 2024 12:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Set token required in Tokenless section under org upload token #3366

feat: Set token required in Tokenless section under org upload token #3366

RulaKhaled commented Oct 8, 2024 •

edited

Loading

codecov-staging bot commented Oct 8, 2024 •

edited

Loading

codecov bot commented Oct 8, 2024 •

edited

Loading

codecov-qa bot commented Oct 8, 2024 •

edited

Loading

codecov-public-qa bot commented Oct 8, 2024 •

edited

Loading

codecov-notifications bot commented Oct 8, 2024 •

edited

Loading

codecov bot commented Oct 9, 2024 •

edited

Loading

codecov-releaser commented Oct 9, 2024 •

edited

Loading

ajay-sentry Oct 9, 2024

RulaKhaled Oct 10, 2024

ajay-sentry Oct 9, 2024

RulaKhaled Oct 10, 2024

ajay-sentry Oct 9, 2024

RulaKhaled Oct 10, 2024

RulaKhaled Oct 10, 2024

ajay-sentry left a comment

feat: Set token required in Tokenless section under org upload token #3366

feat: Set token required in Tokenless section under org upload token #3366

Conversation

RulaKhaled commented Oct 8, 2024 • edited Loading

Description

Notable Changes

Screenshots

Legal Boilerplate

codecov-staging bot commented Oct 8, 2024 • edited Loading

Bundle Report

codecov bot commented Oct 8, 2024 • edited Loading

Bundle Report

codecov-qa bot commented Oct 8, 2024 • edited Loading

Codecov Report

codecov-public-qa bot commented Oct 8, 2024 • edited Loading

Codecov Report

codecov-notifications bot commented Oct 8, 2024 • edited Loading

Codecov Report

codecov bot commented Oct 9, 2024 • edited Loading

Codecov Report

codecov-releaser commented Oct 9, 2024 • edited Loading

✅ Deploy preview for gazebo ready!

ajay-sentry Oct 9, 2024

Choose a reason for hiding this comment

RulaKhaled Oct 10, 2024

Choose a reason for hiding this comment

ajay-sentry Oct 9, 2024

Choose a reason for hiding this comment

RulaKhaled Oct 10, 2024

Choose a reason for hiding this comment

ajay-sentry Oct 9, 2024

Choose a reason for hiding this comment

RulaKhaled Oct 10, 2024

Choose a reason for hiding this comment

RulaKhaled Oct 10, 2024

Choose a reason for hiding this comment

ajay-sentry left a comment

Choose a reason for hiding this comment

RulaKhaled commented Oct 8, 2024 •

edited

Loading

codecov-staging bot commented Oct 8, 2024 •

edited

Loading

codecov bot commented Oct 8, 2024 •

edited

Loading

codecov-qa bot commented Oct 8, 2024 •

edited

Loading

codecov-public-qa bot commented Oct 8, 2024 •

edited

Loading

codecov-notifications bot commented Oct 8, 2024 •

edited

Loading

codecov bot commented Oct 9, 2024 •

edited

Loading

codecov-releaser commented Oct 9, 2024 •

edited

Loading