Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spalmurray/account details card #3382

Merged
merged 3 commits into from
Oct 15, 2024
Merged

spalmurray/account details card #3382

merged 3 commits into from
Oct 15, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov commented Oct 10, 2024 •
edited
Loading

Adds the Account Details card to the plan page when the owner is part of an Account. Org list coming in future PR.

Design

Closes codecov/engineering-team#2562

Screenshot 2024-10-10 at 14 52 48

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review October 10, 2024 18:53
@codecov-staging
Copy link

codecov-staging bot commented Oct 10, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 2.64kB (0.04%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-array-push 6.14MB 2.64kB (0.04%) ⬆️

@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 2.64kB (0.04%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.14MB 2.64kB (0.04%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.18%. Comparing base (c21959b) to head (94f18e8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3382   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         804      805    +1     
  Lines       14228    14232    +4     
  Branches     3921     3927    +6     
=======================================
+ Hits        14112    14116    +4     
  Misses        107      107           
  Partials        9        9
Files with missing lines Coverage Δ
...bRoutes/CurrentOrgPlan/AccountOrgs/AccountOrgs.tsx 100.00% <100.00%> (ø)
...anPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx 100.00% <100.00%> (ø)
...urrentOrgPlan/hooks/useEnterpriseAccountDetails.ts 100.00% <100.00%> (ø)
src/ui/Card/Card.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <100.00%> (+<0.01%) ⬆️
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21959b...94f18e8. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.18%. Comparing base (c21959b) to head (94f18e8).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3382   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         804      805    +1     
  Lines       14228    14232    +4     
  Branches     3921     3922    +1     
=======================================
+ Hits        14112    14116    +4     
  Misses        107      107           
  Partials        9        9
Files Coverage Δ
...bRoutes/CurrentOrgPlan/AccountOrgs/AccountOrgs.tsx 100.00% <100.00%> (ø)
...anPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx 100.00% <100.00%> (ø)
...urrentOrgPlan/hooks/useEnterpriseAccountDetails.ts 100.00% <100.00%> (ø)
src/ui/Card/Card.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <100.00%> (+<0.01%) ⬆️
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21959b...94f18e8. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.18%. Comparing base (c21959b) to head (94f18e8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3382   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         804      805    +1     
  Lines       14228    14232    +4     
  Branches     3921     3927    +6     
=======================================
+ Hits        14112    14116    +4     
  Misses        107      107           
  Partials        9        9
Files with missing lines Coverage Δ
...bRoutes/CurrentOrgPlan/AccountOrgs/AccountOrgs.tsx 100.00% <100.00%> (ø)
...anPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx 100.00% <100.00%> (ø)
...urrentOrgPlan/hooks/useEnterpriseAccountDetails.ts 100.00% <100.00%> (ø)
src/ui/Card/Card.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <100.00%> (+<0.01%) ⬆️
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21959b...94f18e8. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3382   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         804      805    +1     
  Lines       14228    14232    +4     
  Branches     3926     3927    +1     
=======================================
+ Hits        14112    14116    +4     
  Misses        107      107           
  Partials        9        9
Files with missing lines Coverage Δ
...bRoutes/CurrentOrgPlan/AccountOrgs/AccountOrgs.tsx 100.00% <100.00%> (ø)
...anPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx 100.00% <100.00%> (ø)
...urrentOrgPlan/hooks/useEnterpriseAccountDetails.ts 100.00% <100.00%> (ø)
src/ui/Card/Card.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <100.00%> (+<0.01%) ⬆️
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21959b...94f18e8. Read the comment docs.

nicholas-codecov
nicholas-codecov reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of comments to peak at

src/ui/Card/Card.tsx Show resolved Hide resolved
src/pages/PlanPage/subRoutes/CurrentOrgPlan/hooks/useEnterpriseAccountDetails.ts Outdated Show resolved Hide resolved
@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
94f18e8 Tue, 15 Oct 2024 18:53:34 GMT Cloud Enterprise

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit b3910ea Oct 15, 2024
62 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/account-details-card branch October 15, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholas-codecov nicholas-codecov nicholas-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Gazebo] Add Account details card to plan page for multiple org users
3 participants
@spalmurray-codecov @codecov-releaser @nicholas-codecov