chore: Removing CRACO #3393

nicholas-codecov · 2024-10-15T10:42:43Z

Description

This PR removes the last bits of CRACO that we have in the codebase, and moves everything fully over to Vite.

Closes codecov/engineering-team#2125

Notable Changes

Update README
Add head sha to asset and chunk file names
Move to Vite icons fully
CI updates
Remove CRACO index.html
Move some files over from .cjs to .mjs
Remove deps

nicholas-codecov · 2024-10-15T10:45:09Z

Forgot we need worker to be updated with latest shared for some fixes with BA.

codecov-releaser · 2024-10-15T10:48:29Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`c8e9622`	Tue, 15 Oct 2024 10:48:29 GMT	Expired	Expired
`cf2714a`	Tue, 15 Oct 2024 18:04:04 GMT	Expired	Expired
`cf2714a`	Tue, 15 Oct 2024 18:05:28 GMT	Expired	Expired
`15d4800`	Wed, 16 Oct 2024 10:44:31 GMT	Expired	Expired
`9b308b4`	Wed, 16 Oct 2024 17:32:53 GMT	Cloud	Enterprise

codecov-qa · 2024-10-15T18:02:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (1b2bf9f) to head (9b308b4).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3393   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         809      809           
  Lines       14209    14209           
  Branches     3916     3921    +5     
=======================================
  Hits        14092    14092           
  Misses        108      108           
  Partials        9        9

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.93% <ø> (ø)`
Services	`99.45% <ø> (ø)`
Shared	`99.80% <ø> (ø)`
UI	`99.06% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b2bf9f...9b308b4. Read the comment docs.

codecov-public-qa · 2024-10-15T18:02:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (1b2bf9f) to head (9b308b4).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3393   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         809      809           
  Lines       14209    14209           
  Branches     3921     3916    -5     
=======================================
  Hits        14092    14092           
  Misses        108      108           
  Partials        9        9

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.93% <ø> (ø)`
Services	`99.45% <ø> (ø)`
Shared	`99.80% <ø> (ø)`
UI	`99.06% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b2bf9f...9b308b4. Read the comment docs.

codecov · 2024-10-15T18:03:12Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (1b2bf9f) to head (9b308b4).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3393   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         809      809           
  Lines       14209    14209           
  Branches     3916     3916           
=======================================
  Hits        14092    14092           
  Misses        108      108           
  Partials        9        9

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.93% <ø> (ø)`
Services	`99.45% <ø> (ø)`
Shared	`99.80% <ø> (ø)`
UI	`99.06% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b2bf9f...9b308b4. Read the comment docs.

codecov-notifications · 2024-10-15T18:03:33Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3393   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         809      809           
  Lines       14209    14209           
  Branches     3921     3921           
=======================================
  Hits        14092    14092           
  Misses        108      108           
  Partials        9        9

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.93% <ø> (ø)`
Services	`99.45% <ø> (ø)`
Shared	`99.80% <ø> (ø)`
UI	`99.06% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b2bf9f...9b308b4. Read the comment docs.

codecov-staging · 2024-10-16T10:40:47Z

Bundle Report

Changes will increase total bundle size by 5.26MB (85.75%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name	Size	Change
gazebo-staging-system-esm	5.26MB	5.26MB (100%) ⬆️⚠️

codecov · 2024-10-16T10:40:47Z

Bundle Report

Changes will increase total bundle size by 10.49MB (171.0%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name	Size	Change
gazebo-production-system	5.23MB	5.23MB (100%) ⬆️⚠️
gazebo-production-system-esm	5.26MB	5.26MB (100%) ⬆️⚠️

suejung-sentry

Nothing blocking that I see - a couple nits in the README. Approved it!

README.md

suejung-sentry · 2024-10-16T15:46:40Z

package.json

-    "test:vite": "yarn generate-icons:vite && vitest run --changed --config ./vitest.config.mjs",
-    "test:watch:vite": "yarn generate-icons:vite && vitest watch --changed --config ./vitest.config.mjs",
-    "test:ci:vite": "yarn generate-icons:vite && vitest run --config ./vitest.config.mjs --coverage",
+    "dev:vite": "yarn start",


Per our chat, the commands with suffix :vite ones with get removed in a separate phase after Infra does stuff

suejung-sentry · 2024-10-16T15:50:19Z

package.json

@@ -36,18 +32,6 @@
      "eslint --fix --no-ignore --max-warnings=0 -c .eslintrc.cjs"
    ]
  },
-  "browserslist": {


nice. thanks.
for any readers of this PR, this is removed for this

suejung-sentry · 2024-10-16T15:54:15Z

public/index.html

@@ -1,72 +0,0 @@
-<!DOCTYPE html>


What purpose was this file serving before out of curiosity?

This was the index.html that CRACO (Webapck) was using to bundle with. With Vite this has moved to the src directory as required by Vite.

suejung-sentry · 2024-10-16T15:59:31Z

yarn.lock

@@ -23102,7 +22768,7 @@ __metadata:
  languageName: node
  linkType: hard

-"webpack@npm:^5.64.4, webpack@npm:^5.94.0":
+"webpack@npm:^5.64.4":


Per our discussion this (webpack) may still be here for storybook

nicholas-codecov force-pushed the gh-eng-2125-remove-craco-for-good branch from cf2714a to 15d4800 Compare October 16, 2024 10:38

suejung-sentry approved these changes Oct 16, 2024

View reviewed changes

nicholas-codecov added 17 commits October 16, 2024 14:16

update scripts and deps

aaa9d33

remove craco configs

fb1c64f

revert icons script back to one, only for vite

43d7abf

vite icons

40fdadd

add eslint rule to icons script

5775151

remove index.html and remove thing from storybook

b761377

update CI

6a76f5d

refresh the readme

f2725f1

conditionally add the commit sha to the asset and chunk file names

34af654

move tailwind over to mjs

6ee2cce

bump postcss to mjs from cjs

296bdd9

build staging stats correctly

b23a7d0

add comment into ci

fd8a3c9

temp disable uploading of bundle stats

2f37b69

small tweak to vite config

05b8fd6

enable BA uploads

9f10374

fix up small small typos in readme

9b308b4

nicholas-codecov force-pushed the gh-eng-2125-remove-craco-for-good branch from 15d4800 to 9b308b4 Compare October 16, 2024 17:26

nicholas-codecov added this pull request to the merge queue Oct 16, 2024

Merged via the queue into main with commit 8a692ce Oct 16, 2024
62 checks passed

nicholas-codecov deleted the gh-eng-2125-remove-craco-for-good branch October 16, 2024 18:01

suejung-sentry mentioned this pull request Oct 16, 2024

chore: Fix tailwind config #3402

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Removing CRACO #3393

chore: Removing CRACO #3393

nicholas-codecov commented Oct 15, 2024

nicholas-codecov commented Oct 15, 2024

codecov-releaser commented Oct 15, 2024 •

edited

Loading

codecov-qa bot commented Oct 15, 2024 •

edited

Loading

codecov-public-qa bot commented Oct 15, 2024 •

edited

Loading

codecov bot commented Oct 15, 2024 •

edited

Loading

codecov-notifications bot commented Oct 15, 2024 •

edited

Loading

codecov-staging bot commented Oct 16, 2024 •

edited

Loading

codecov bot commented Oct 16, 2024 •

edited

Loading

suejung-sentry left a comment

suejung-sentry Oct 16, 2024

suejung-sentry Oct 16, 2024

suejung-sentry Oct 16, 2024

nicholas-codecov Oct 16, 2024

suejung-sentry Oct 16, 2024

chore: Removing CRACO #3393

chore: Removing CRACO #3393

Conversation

nicholas-codecov commented Oct 15, 2024

Description

Notable Changes

nicholas-codecov commented Oct 15, 2024

codecov-releaser commented Oct 15, 2024 • edited Loading

✅ Deploy preview for gazebo ready!

codecov-qa bot commented Oct 15, 2024 • edited Loading

Codecov Report

codecov-public-qa bot commented Oct 15, 2024 • edited Loading

Codecov Report

codecov bot commented Oct 15, 2024 • edited Loading

Codecov Report

codecov-notifications bot commented Oct 15, 2024 • edited Loading

Codecov Report

codecov-staging bot commented Oct 16, 2024 • edited Loading

Bundle Report

codecov bot commented Oct 16, 2024 • edited Loading

Bundle Report

suejung-sentry left a comment

Choose a reason for hiding this comment

suejung-sentry Oct 16, 2024

Choose a reason for hiding this comment

suejung-sentry Oct 16, 2024

Choose a reason for hiding this comment

suejung-sentry Oct 16, 2024

Choose a reason for hiding this comment

nicholas-codecov Oct 16, 2024

Choose a reason for hiding this comment

suejung-sentry Oct 16, 2024

Choose a reason for hiding this comment

codecov-releaser commented Oct 15, 2024 •

edited

Loading

codecov-qa bot commented Oct 15, 2024 •

edited

Loading

codecov-public-qa bot commented Oct 15, 2024 •

edited

Loading

codecov bot commented Oct 15, 2024 •

edited

Loading

codecov-notifications bot commented Oct 15, 2024 •

edited

Loading

codecov-staging bot commented Oct 16, 2024 •

edited

Loading

codecov bot commented Oct 16, 2024 •

edited

Loading