Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[launchweek-demo] Add login form #3395

Closed
wants to merge 3 commits into from

Conversation

rohitvinnakota-codecov
Copy link
Contributor

Description
This PR adds an email form component and associated event handling logic.

@rohitvinnakota-codecov rohitvinnakota-codecov changed the title Add email form Add login form Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Bundle Report

Bundle size has no change ✅

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/ui/LoginForm/LoginForm.tsx 0.00% 12 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3395      +/-   ##
==========================================
- Coverage   99.18%   99.09%   -0.10%     
==========================================
  Files         803      804       +1     
  Lines       14210    14223      +13     
  Branches     3916     3917       +1     
==========================================
  Hits        14094    14094              
- Misses        107      119      +12     
- Partials        9       10       +1     
Files with missing lines Coverage Δ
src/ui/LoginForm/LoginForm.tsx 0.00% <0.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 98.22% <0.00%> (-0.88%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a5a12...38340e0. Read the comment docs.

Copy link

codecov bot commented Oct 15, 2024

❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

2 similar comments
Copy link

codecov-public-qa bot commented Oct 15, 2024

❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

@codecov-qa
Copy link

codecov-qa bot commented Oct 15, 2024

❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
38340e0 Tue, 15 Oct 2024 16:39:50 GMT Cloud Enterprise

@rohitvinnakota-codecov
Copy link
Contributor Author

@codecov-ai-reviewer review

Comment on lines +15 to +16
setUsername(username)
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setUsername call here is redundant since username is already set. You can remove this line.

Co-authored-by: codecov-ai-reviewer[bot] <156709835+codecov-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: codecov-ai-reviewer[bot] <156709835+codecov-ai-reviewer[bot]@users.noreply.github.com>
@rohitvinnakota-codecov rohitvinnakota-codecov changed the title Add login form [launchweek-demo] Add login form Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants