-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add CI status tooltip #3411
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3411 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 808 808
Lines 14267 14268 +1
Branches 3949 3949
=======================================
+ Hits 14146 14147 +1
Misses 112 112
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3411 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 808 808
Lines 14267 14268 +1
Branches 3942 3949 +7
=======================================
+ Hits 14146 14147 +1
Misses 112 112
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 2.76kB (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3411 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 808 808
Lines 14267 14268 +1
Branches 3949 3942 -7
=======================================
+ Hits 14146 14147 +1
Misses 112 112
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3411 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 808 808
Lines 14267 14268 +1
Branches 3942 3949 +7
=======================================
+ Hits 14146 14147 +1
Misses 112 112
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 2.76kB (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
674d306
to
669d62d
Compare
@@ -506,5 +506,12 @@ export function useStaticNavLinks() { | |||
isExternalLink: true, | |||
openNewTab: true, | |||
}, | |||
requireCIPassDocs: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add this to the useStaticNavLinks.test file too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a test assertion I mean
fa1415b
to
c87192a
Compare
Description
Closes codecov/engineering-team#2523
Discussed with Adalene and we decided to do away with the border style to match with the tooltips on their way for TA.
Code Example
Notable Changes
Screenshots
Looked into the reason why we had z-30 in SummaryDropdown and it looks like we don't currently need it.
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.