Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add CI status tooltip #3411

Merged
merged 6 commits into from
Oct 23, 2024
Merged

feat: Add CI status tooltip #3411

merged 6 commits into from
Oct 23, 2024

Conversation

calvin-codecov
Copy link
Contributor

@calvin-codecov calvin-codecov commented Oct 18, 2024

Description

Closes codecov/engineering-team#2523

Discussed with Adalene and we decided to do away with the border style to match with the tooltips on their way for TA.

Code Example

Notable Changes

Screenshots

Screenshot 2024-10-22 at 1 42 31 PM

Looked into the reason why we had z-30 in SummaryDropdown and it looks like we don't currently need it.
Screenshot 2024-10-23 at 9 28 28 AM
Screenshot 2024-10-23 at 9 28 12 AM

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov-public-qa bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (8d85d79) to head (72904f3).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3411   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files         808      808           
  Lines       14267    14268    +1     
  Branches     3949     3949           
=======================================
+ Hits        14146    14147    +1     
  Misses        112      112           
  Partials        9        9           
Files Coverage Δ
...rvices/navigation/useNavLinks/useStaticNavLinks.js 98.83% <100.00%> (+0.01%) ⬆️
src/ui/CIStatus/CIStatus.tsx 100.00% <100.00%> (ø)
src/ui/SummaryDropdown/SummaryDropdown.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.89% <ø> (ø)
Services 99.45% <100.00%> (+<0.01%) ⬆️
Shared 99.80% <ø> (ø)
UI 99.06% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d85d79...72904f3. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (8d85d79) to head (72904f3).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3411   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files         808      808           
  Lines       14267    14268    +1     
  Branches     3942     3949    +7     
=======================================
+ Hits        14146    14147    +1     
  Misses        112      112           
  Partials        9        9           
Files with missing lines Coverage Δ
...rvices/navigation/useNavLinks/useStaticNavLinks.js 98.83% <100.00%> (+0.01%) ⬆️
src/ui/CIStatus/CIStatus.tsx 100.00% <100.00%> (ø)
src/ui/SummaryDropdown/SummaryDropdown.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.89% <ø> (ø)
Services 99.45% <100.00%> (+<0.01%) ⬆️
Shared 99.80% <ø> (ø)
UI 99.06% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d85d79...72904f3. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Oct 18, 2024

Bundle Report

Changes will increase total bundle size by 2.76kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.55MB 1.37kB (0.02%) ⬆️
gazebo-staging-system 5.5MB 1.39kB (0.03%) ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Oct 18, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
af7989b Fri, 18 Oct 2024 23:16:17 GMT Expired Expired
21cba28 Mon, 21 Oct 2024 20:28:56 GMT Expired Expired
53664d6 Tue, 22 Oct 2024 17:32:16 GMT Expired Expired
674d306 Tue, 22 Oct 2024 21:45:29 GMT Expired Expired
669d62d Wed, 23 Oct 2024 08:12:26 GMT Expired Expired
fa1415b Wed, 23 Oct 2024 17:36:25 GMT Expired Expired
fa1415b Wed, 23 Oct 2024 17:43:04 GMT Expired Expired
c87192a Wed, 23 Oct 2024 18:07:38 GMT Cloud Enterprise

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (8d85d79) to head (72904f3).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3411   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files         808      808           
  Lines       14267    14268    +1     
  Branches     3949     3942    -7     
=======================================
+ Hits        14146    14147    +1     
  Misses        112      112           
  Partials        9        9           
Files with missing lines Coverage Δ
...rvices/navigation/useNavLinks/useStaticNavLinks.js 98.83% <100.00%> (+0.01%) ⬆️
src/ui/CIStatus/CIStatus.tsx 100.00% <100.00%> (ø)
src/ui/SummaryDropdown/SummaryDropdown.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.89% <ø> (ø)
Services 99.45% <100.00%> (+<0.01%) ⬆️
Shared 99.80% <ø> (ø)
UI 99.06% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d85d79...72904f3. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3411   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files         808      808           
  Lines       14267    14268    +1     
  Branches     3942     3949    +7     
=======================================
+ Hits        14146    14147    +1     
  Misses        112      112           
  Partials        9        9           
Files with missing lines Coverage Δ
...rvices/navigation/useNavLinks/useStaticNavLinks.js 98.83% <100.00%> (+0.01%) ⬆️
src/ui/CIStatus/CIStatus.tsx 100.00% <100.00%> (ø)
src/ui/SummaryDropdown/SummaryDropdown.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.89% <ø> (ø)
Services 99.45% <100.00%> (+<0.01%) ⬆️
Shared 99.80% <ø> (ø)
UI 99.06% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d85d79...72904f3. Read the comment docs.

Copy link

codecov bot commented Oct 21, 2024

Bundle Report

Changes will increase total bundle size by 2.76kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.5MB 1.39kB (0.03%) ⬆️
gazebo-production-system-esm 5.55MB 1.37kB (0.02%) ⬆️

@calvin-codecov calvin-codecov force-pushed the cy/ci_status_tooltip branch 3 times, most recently from 674d306 to 669d62d Compare October 23, 2024 08:06
@@ -506,5 +506,12 @@ export function useStaticNavLinks() {
isExternalLink: true,
openNewTab: true,
},
requireCIPassDocs: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add this to the useStaticNavLinks.test file too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a test assertion I mean

@calvin-codecov calvin-codecov added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit fc871b2 Oct 23, 2024
61 checks passed
@calvin-codecov calvin-codecov deleted the cy/ci_status_tooltip branch October 23, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip for explaining CI status
3 participants