fix: Pass in interval to aggregate functions, dynamic copy updates for intervals #3424

ajay-sentry · 2024-10-22T20:56:17Z

Description

This PR does a small feature add passing in the historicalTrend parameter to the "interval" filter for both the testResultsAggregates and flakeAggregates queries, and does some minor dynamic copy updates taking into account that filter if it exists.

I chose not to use this thing because it was hard coded to have the capitals at the beginning of the label and I needed something a little more precise for my use case.

gazebo/src/pages/RepoPage/shared/constants.ts

Lines 9 to 13 in 88d2ec9

    
           export const MeasurementTimeOptions = [ 
        
             { label: 'Last 30 days', value: MEASUREMENT_INTERVAL.INTERVAL_30_DAY }, 
        
             { label: 'Last 7 days', value: MEASUREMENT_INTERVAL.INTERVAL_7_DAY }, 
        
             { label: 'Last day', value: MEASUREMENT_INTERVAL.INTERVAL_1_DAY }, 
        
           ] as const

Screenshots

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

…ry (#3384)

…into tests-analytics-v2

…3388)

Co-authored-by: Ajay Singh <[email protected]>

…into tests-analytics-v2

… Page (#3419)

…3420)

codecov-staging · 2024-10-22T21:00:04Z

Bundle Report

Changes will increase total bundle size by 1.08kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-staging-system-esm	5.58MB	712 bytes (0.01%) ⬆️
gazebo-staging-system	5.52MB	371 bytes (0.01%) ⬆️

codecov-notifications · 2024-10-22T21:01:40Z

Codecov Report

Attention: Patch coverage is 95.28986% with 13 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
.../FailedTestsPage/MetricsSection/MetricsSection.tsx	91.13%	7 Missing ⚠️
...ledTestsPage/FailedTestsTable/FailedTestsTable.tsx	92.15%	4 Missing ⚠️
...ailedTestsPage/SelectorSection/SelectorSection.tsx	95.74%	2 Missing ⚠️

@@            Coverage Diff             @@
##             main    #3424      +/-   ##
==========================================
- Coverage   99.15%   99.07%   -0.08%     
==========================================
  Files         809      817       +8     
  Lines       14275    14533     +258     
  Branches     3935     4020      +85     
==========================================
+ Hits        14154    14399     +245     
- Misses        112      125      +13     
  Partials        9        9

Files with missing lines	Coverage Δ
...FailedTestsTab/FailedTestsPage/FailedTestsPage.tsx	`100.00% <100.00%> (ø)`
.../SelectorSection/BranchSelector/BranchSelector.tsx	`100.00% <ø> (ø)`
...stsTab/FailedTestsPage/TableHeader/TableHeader.tsx	`100.00% <100.00%> (ø)`
...ge/hooks/useFlakeAggregates/useFlakeAggregates.tsx	`100.00% <100.00%> (ø)`
.../useInfiniteTestResults/useInfiniteTestResults.tsx	`100.00% <100.00%> (ø)`
...TestResultsAggregates/useTestResultsAggregates.tsx	`100.00% <100.00%> (ø)`
.../hooks/useTestResultsFlags/useTestResultsFlags.tsx	`100.00% <100.00%> (ø)`
...TestResultsTestSuites/useTestResultsTestSuites.tsx	`100.00% <100.00%> (ø)`
...c/pages/RepoPage/FailedTestsTab/FailedTestsTab.tsx	`93.10% <ø> (ø)`
src/pages/RepoPage/shared/constants.ts	`100.00% <100.00%> (ø)`
... and 5 more

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.77% <95.09%> (-0.13%)`	⬇️
Services	`99.45% <100.00%> (+<0.01%)`	⬆️
Shared	`99.80% <100.00%> (+<0.01%)`	⬆️
UI	`99.06% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddf8ef4...88d2ec9. Read the comment docs.

codecov-qa · 2024-10-22T21:01:40Z

Codecov Report

Attention: Patch coverage is 95.28986% with 13 lines in your changes missing coverage. Please review.

Project coverage is 99.07%. Comparing base (ddf8ef4) to head (88d2ec9).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
.../FailedTestsPage/MetricsSection/MetricsSection.tsx	91.13%	7 Missing ⚠️
...ledTestsPage/FailedTestsTable/FailedTestsTable.tsx	92.15%	4 Missing ⚠️
...ailedTestsPage/SelectorSection/SelectorSection.tsx	95.74%	2 Missing ⚠️

@@            Coverage Diff             @@
##             main    #3424      +/-   ##
==========================================
- Coverage   99.15%   99.07%   -0.08%     
==========================================
  Files         809      817       +8     
  Lines       14275    14533     +258     
  Branches     3942     4020      +78     
==========================================
+ Hits        14154    14399     +245     
- Misses        112      125      +13     
  Partials        9        9

Files with missing lines	Coverage Δ
...FailedTestsTab/FailedTestsPage/FailedTestsPage.tsx	`100.00% <100.00%> (ø)`
.../SelectorSection/BranchSelector/BranchSelector.tsx	`100.00% <ø> (ø)`
...stsTab/FailedTestsPage/TableHeader/TableHeader.tsx	`100.00% <100.00%> (ø)`
...ge/hooks/useFlakeAggregates/useFlakeAggregates.tsx	`100.00% <100.00%> (ø)`
.../useInfiniteTestResults/useInfiniteTestResults.tsx	`100.00% <100.00%> (ø)`
...TestResultsAggregates/useTestResultsAggregates.tsx	`100.00% <100.00%> (ø)`
.../hooks/useTestResultsFlags/useTestResultsFlags.tsx	`100.00% <100.00%> (ø)`
...TestResultsTestSuites/useTestResultsTestSuites.tsx	`100.00% <100.00%> (ø)`
...c/pages/RepoPage/FailedTestsTab/FailedTestsTab.tsx	`93.10% <ø> (ø)`
src/pages/RepoPage/shared/constants.ts	`100.00% <100.00%> (ø)`
... and 5 more

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.77% <95.09%> (-0.13%)`	⬇️
Services	`99.45% <100.00%> (+<0.01%)`	⬆️
Shared	`99.80% <100.00%> (+<0.01%)`	⬆️
UI	`99.06% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddf8ef4...88d2ec9. Read the comment docs.

codecov · 2024-10-22T21:02:05Z

Codecov Report

Attention: Patch coverage is 95.28986% with 13 lines in your changes missing coverage. Please review.

Project coverage is 99.07%. Comparing base (ddf8ef4) to head (88d2ec9).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
.../FailedTestsPage/MetricsSection/MetricsSection.tsx	91.13%	7 Missing ⚠️
...ledTestsPage/FailedTestsTable/FailedTestsTable.tsx	92.15%	4 Missing ⚠️
...ailedTestsPage/SelectorSection/SelectorSection.tsx	95.74%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3424      +/-   ##
==========================================
- Coverage   99.15%   99.07%   -0.08%     
==========================================
  Files         809      817       +8     
  Lines       14275    14533     +258     
  Branches     3942     4020      +78     
==========================================
+ Hits        14154    14399     +245     
- Misses        112      125      +13     
  Partials        9        9

Files with missing lines	Coverage Δ
...FailedTestsTab/FailedTestsPage/FailedTestsPage.tsx	`100.00% <100.00%> (ø)`
.../SelectorSection/BranchSelector/BranchSelector.tsx	`100.00% <ø> (ø)`
...stsTab/FailedTestsPage/TableHeader/TableHeader.tsx	`100.00% <100.00%> (ø)`
...ge/hooks/useFlakeAggregates/useFlakeAggregates.tsx	`100.00% <100.00%> (ø)`
.../useInfiniteTestResults/useInfiniteTestResults.tsx	`100.00% <100.00%> (ø)`
...TestResultsAggregates/useTestResultsAggregates.tsx	`100.00% <100.00%> (ø)`
.../hooks/useTestResultsFlags/useTestResultsFlags.tsx	`100.00% <100.00%> (ø)`
...TestResultsTestSuites/useTestResultsTestSuites.tsx	`100.00% <100.00%> (ø)`
...c/pages/RepoPage/FailedTestsTab/FailedTestsTab.tsx	`93.10% <ø> (ø)`
src/pages/RepoPage/shared/constants.ts	`100.00% <100.00%> (ø)`
... and 5 more

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.77% <95.09%> (-0.13%)`	⬇️
Services	`99.45% <100.00%> (+<0.01%)`	⬆️
Shared	`99.80% <100.00%> (+<0.01%)`	⬆️
UI	`99.06% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddf8ef4...88d2ec9. Read the comment docs.

codecov · 2024-10-22T21:02:33Z

Bundle Report

Changes will increase total bundle size by 1.08kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-production-system	5.52MB	371 bytes (0.01%) ⬆️
gazebo-production-system-esm	5.58MB	712 bytes (0.01%) ⬆️

codecov-releaser · 2024-10-22T21:02:54Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`88d2ec9`	Tue, 22 Oct 2024 21:02:54 GMT	Cloud	Enterprise

RulaKhaled and others added 30 commits September 10, 2024 10:44

feat: Create metrics section for tests analytics page (#3171)

6360d0c

Merge branch 'main' into tests-analytics-v2

b95af5a

feat: Creating new tests analytics columns / fix styles (#3177)

f87e980

Merge branch 'main' into tests-analytics-v2

ec95735

Feat: Add dummy selectors to FailedTestsPage (#3188)

aa8fa23

fix: Add tooltip and correct styling to flake rate column header (#3221)

555e411

ref: refactor page components into separate sections (#3231)

d788b78

Merge branch 'main' into tests-analytics-v2

e7c5215

Merge branch 'main' into tests-analytics-v2

b3e3099

rebase and fix failing tests

1a5e4ff

feat: Update FailedTests Table to use FlakeRate (#3364)

030012b

Merge branch 'main' into tests-analytics-v2

950ded2

feat: Add new hook to fetch test results aggregates (#3368)

688cfdb

Merge branch 'main' into tests-analytics-v2

3f23c1c

chore: Handle merge conflicts with graphql restructure (#3378)

a6592b2

Merge branch 'main' into tests-analytics-v2

f9214bb

feat: Link hook to metrics section, make percent badge dynamic (#3379)

4a58220

feat: Glue in pass/fail/skip params into tooltip via test results que…

6817eb9

…ry (#3384)

Merge branch 'main' into tests-analytics-v2

4419a37

feat: New flake aggregates hook (#3389)

1053b2e

feat: Plan specific details, flake rate related stuff (#3394)

834f513

Merge branch 'tests-analytics-v2' of https://github.com/codecov/gazebo …

648b250

…into tests-analytics-v2

Merge branch 'main' into tests-analytics-v2

7a3df9d

feat: Add filter param onchange logic and link to test results query (#…

5f6dcfe

…3388)

fix: Format date for durations in TA (#3397)

c874493

feat: Test Analytics Metrics buttons and small query linkages (#3400)

a6395f2

merge conflicts

2d1a191

feat: Minor Polish for Failed Tests Table (#3412)

cfa0c2b

feat: Adding table header to TA (#3409)

3109bd1

Co-authored-by: Ajay Singh <[email protected]>

fix: Type fix for Total Count (#3417)

c839a51

ajay-sentry and others added 6 commits October 21, 2024 11:24

Merge branch 'main' into tests-analytics-v2

88f3df6

Merge branch 'tests-analytics-v2' of https://github.com/codecov/gazebo …

b89327e

…into tests-analytics-v2

feat: Add new Hooks for fetching testSuites and flags on Failed Tests…

4e17b08

… Page (#3419)

feat: Link Flags/Test Suites hooks to Failed Tests Table Selectors (#…

4e14049

…3420)

feat: Update with table tests header (#3421)

590d5be

add measurement interval param, dynamic copy otherwise

88d2ec9

ajay-sentry closed this Oct 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Pass in interval to aggregate functions, dynamic copy updates for intervals #3424

fix: Pass in interval to aggregate functions, dynamic copy updates for intervals #3424

ajay-sentry commented Oct 22, 2024

codecov-staging bot commented Oct 22, 2024 •

edited

Loading

codecov-notifications bot commented Oct 22, 2024

codecov-qa bot commented Oct 22, 2024

codecov bot commented Oct 22, 2024 •

edited

Loading

codecov bot commented Oct 22, 2024

codecov-releaser commented Oct 22, 2024

	export const MeasurementTimeOptions = [
	{ label: 'Last 30 days', value: MEASUREMENT_INTERVAL.INTERVAL_30_DAY },
	{ label: 'Last 7 days', value: MEASUREMENT_INTERVAL.INTERVAL_7_DAY },
	{ label: 'Last day', value: MEASUREMENT_INTERVAL.INTERVAL_1_DAY },
	] as const

fix: Pass in interval to aggregate functions, dynamic copy updates for intervals #3424

fix: Pass in interval to aggregate functions, dynamic copy updates for intervals #3424

Conversation

ajay-sentry commented Oct 22, 2024

Description

Screenshots

Link to Sample Entry

Legal Boilerplate

codecov-staging bot commented Oct 22, 2024 • edited Loading

Bundle Report

codecov-notifications bot commented Oct 22, 2024

Codecov Report

codecov-qa bot commented Oct 22, 2024

Codecov Report

codecov bot commented Oct 22, 2024 • edited Loading

Codecov Report

codecov bot commented Oct 22, 2024

Bundle Report

codecov-releaser commented Oct 22, 2024

✅ Deploy preview for gazebo ready!

codecov-staging bot commented Oct 22, 2024 •

edited

Loading

codecov bot commented Oct 22, 2024 •

edited

Loading