Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Change errored uploads and uploads list text #3429

Merged
merged 2 commits into from
Oct 23, 2024
Merged

feat: Change errored uploads and uploads list text #3429

merged 2 commits into from
Oct 23, 2024

Conversation

calvin-codecov
Copy link
Contributor

@calvin-codecov calvin-codecov commented Oct 23, 2024 •
edited
Loading

Description

Closes codecov/engineering-team#2521

Figma: https://www.figma.com/design/4Z7yb2dkIIATkfzpWoMYQq/GH-2220?node-id=1-2

We're addressing point 4 and 5 of the Figma file

Code Example

Notable Changes

Removing old, unhelpful messaging and replacing with this new one. Anytime a commit has an upload error currently, the UI will be forever stuck show our existing messaging
Screenshot 2024-10-22 at 1 11 47 AM

Screenshots

Screenshot 2024-10-23 at 10 59 02 AM

@codecov-staging
Copy link

codecov-staging bot commented Oct 23, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 18 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.55MB 43 bytes (0.0%) ⬆️
gazebo-staging-system 5.5MB 25 bytes (-0.0%) ⬇️

@codecov Codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 18 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.5MB 25 bytes (-0.0%) ⬇️
gazebo-production-system-esm 5.55MB 43 bytes (0.0%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (04fec25) to head (4a9387b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3429      +/-   ##
==========================================
- Coverage   99.15%   99.15%   -0.01%     
==========================================
  Files         808      808              
  Lines       14273    14267       -6     
  Branches     3944     3942       -2     
==========================================
- Hits        14152    14146       -6     
  Misses        112      112              
  Partials        9        9
Files with missing lines Coverage Δ
...e/CommitCoverage/ErroredUploads/ErroredUploads.jsx 100.00% <100.00%> (ø)
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx 100.00% <ø> (ø)
...mitDetailPage/Dropdowns/CommitCoverageDropdown.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.89% <100.00%> (-0.01%) ⬇️
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.06% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04fec25...4a9387b. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3429      +/-   ##
==========================================
- Coverage   99.15%   99.15%   -0.01%     
==========================================
  Files         808      808              
  Lines       14273    14267       -6     
  Branches     3944     3942       -2     
==========================================
- Hits        14152    14146       -6     
  Misses        112      112              
  Partials        9        9
Files with missing lines Coverage Δ
...e/CommitCoverage/ErroredUploads/ErroredUploads.jsx 100.00% <100.00%> (ø)
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx 100.00% <ø> (ø)
...mitDetailPage/Dropdowns/CommitCoverageDropdown.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.89% <100.00%> (-0.01%) ⬇️
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.06% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04fec25...4a9387b. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (04fec25) to head (4a9387b).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3429      +/-   ##
==========================================
- Coverage   99.15%   99.15%   -0.01%     
==========================================
  Files         808      808              
  Lines       14273    14267       -6     
  Branches     3951     3949       -2     
==========================================
- Hits        14152    14146       -6     
  Misses        112      112              
  Partials        9        9
Files Coverage Δ
...e/CommitCoverage/ErroredUploads/ErroredUploads.jsx 100.00% <100.00%> (ø)
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx 100.00% <ø> (ø)
...mitDetailPage/Dropdowns/CommitCoverageDropdown.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.89% <100.00%> (-0.01%) ⬇️
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.06% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04fec25...4a9387b. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (04fec25) to head (4a9387b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3429      +/-   ##
==========================================
- Coverage   99.15%   99.15%   -0.01%     
==========================================
  Files         808      808              
  Lines       14273    14267       -6     
  Branches     3951     3942       -9     
==========================================
- Hits        14152    14146       -6     
  Misses        112      112              
  Partials        9        9
Files with missing lines Coverage Δ
...e/CommitCoverage/ErroredUploads/ErroredUploads.jsx 100.00% <100.00%> (ø)
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx 100.00% <ø> (ø)
...mitDetailPage/Dropdowns/CommitCoverageDropdown.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.89% <100.00%> (-0.01%) ⬇️
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.06% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04fec25...4a9387b. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Oct 23, 2024 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
8362edd Wed, 23 Oct 2024 17:43:05 GMT Expired Expired
4a9387b Wed, 23 Oct 2024 18:09:24 GMT Cloud Enterprise

spalmurray-codecov
spalmurray-codecov approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@calvin-codecov calvin-codecov added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 8d85d79 Oct 23, 2024
62 checks passed
@calvin-codecov calvin-codecov deleted the cy/update_cov_report_history_ui branch October 23, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalmurray-codecov spalmurray-codecov spalmurray-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update UI copy for Coverage reports history and the body of the no coverage data description
3 participants
@calvin-codecov @codecov-releaser @spalmurray-codecov