feat: Pin default branch to top of branch selector items #3477
Conversation
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
| @@ -89,7 +89,17 @@ const BranchSelector = () => { | |||
| // @ts-expect-error - Select has some TS issues because it's still written in JS | |||
| dataMarketing="branch-selector-test-results-tab" | |||
| ariaName="test results branch selector" | |||
| items={branchList?.branches ?? []} | |||
| items={ | |||
| overview?.defaultBranch | |||
There was a problem hiding this comment.
I think it might be cleaner if we define a function for this logic and just do items={getBranchItems()}. Up to you
There was a problem hiding this comment.
I can get behind that, I also wasn't a huge fan of stuffing it in. Will make the update before merging
There was a problem hiding this comment.
Fixed in 6c8a8ce
Bundle ReportChanges will increase total bundle size by 373 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will increase total bundle size by 373 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## tests-analytics-v2 #3477 +/- ##
===================================================
Coverage 99.01% 99.01%
===================================================
Files 812 812
Lines 14448 14453 +5
Branches 4113 4117 +4
===================================================
+ Hits 14306 14311 +5
Misses 133 133
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## tests-analytics-v2 #3477 +/- ##
===================================================
Coverage 99.01% 99.01%
===================================================
Files 812 812
Lines 14448 14453 +5
Branches 4113 4110 -3
===================================================
+ Hits 14306 14311 +5
Misses 133 133
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## tests-analytics-v2 #3477 +/- ##
===================================================
Coverage 99.01% 99.01%
===================================================
Files 812 812
Lines 14448 14453 +5
Branches 4113 4110 -3
===================================================
+ Hits 14306 14311 +5
Misses 133 133
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## tests-analytics-v2 #3477 +/- ##
===================================================
Coverage 99.01% 99.01%
===================================================
Files 812 812
Lines 14448 14453 +5
Branches 4113 4110 -3
===================================================
+ Hits 14306 14311 +5
Misses 133 133
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Description
This PR aims to pin the default branch (if it exists) to the top of the list of branches on the Branch Selector for the Failed Tests tab.
This is a quality of life fix to make it easy for folks to go back to the "main" view.
Closes codecov/engineering-team#2855
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.