Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: center selectors on bundles page #3479

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

ajay-sentry
Copy link
Contributor

@ajay-sentry ajay-sentry commented Nov 8, 2024

Description

This PR centers the selectors on the bundles tab to match the new TA format.

Screenshots

AFTER

Screen.Recording.2024-11-08.at.10.42.07.AM.mov

BEFORE

Screen.Recording.2024-11-08.at.10.42.53.AM.mov

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Nov 8, 2024

Bundle Report

Changes will increase total bundle size by 256 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.59MB 33 bytes (-0.0%) ⬇️
gazebo-staging-system 5.54MB 289 bytes (0.01%) ⬆️

Copy link

codecov bot commented Nov 8, 2024

Bundle Report

Changes will increase total bundle size by 256 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.54MB 289 bytes (0.01%) ⬆️
gazebo-production-system-esm 5.59MB 33 bytes (-0.0%) ⬇️

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.16%. Comparing base (96f88d8) to head (3953588).
Report is 15 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3479      +/-   ##
==========================================
+ Coverage   99.09%   99.16%   +0.07%     
==========================================
  Files         804      802       -2     
  Lines       14187    14150      -37     
  Branches     4024     4008      -16     
==========================================
- Hits        14058    14032      -26     
+ Misses        120      111       -9     
+ Partials        9        7       -2     
Files with missing lines Coverage Δ
.../BundleContent/BundleSelection/BundleSelection.tsx 100.00% <ø> (ø)

... and 14 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <ø> (+0.13%) ⬆️
Services 99.36% <ø> (+<0.01%) ⬆️
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f88d8...3953588. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3479      +/-   ##
==========================================
+ Coverage   99.09%   99.16%   +0.07%     
==========================================
  Files         804      802       -2     
  Lines       14187    14150      -37     
  Branches     4017     4015       -2     
==========================================
- Hits        14058    14032      -26     
+ Misses        120      111       -9     
+ Partials        9        7       -2     
Files with missing lines Coverage Δ
.../BundleContent/BundleSelection/BundleSelection.tsx 100.00% <ø> (ø)

... and 14 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <ø> (+0.13%) ⬆️
Services 99.36% <ø> (+<0.01%) ⬆️
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f88d8...3953588. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.16%. Comparing base (96f88d8) to head (3953588).
Report is 15 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3479      +/-   ##
==========================================
+ Coverage   99.09%   99.16%   +0.07%     
==========================================
  Files         804      802       -2     
  Lines       14187    14150      -37     
  Branches     4024     4008      -16     
==========================================
- Hits        14058    14032      -26     
+ Misses        120      111       -9     
+ Partials        9        7       -2     
Files with missing lines Coverage Δ
.../BundleContent/BundleSelection/BundleSelection.tsx 100.00% <ø> (ø)

... and 14 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <ø> (+0.13%) ⬆️
Services 99.36% <ø> (+<0.01%) ⬆️
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f88d8...3953588. Read the comment docs.

Copy link

codecov-public-qa bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.16%. Comparing base (96f88d8) to head (3953588).
Report is 15 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3479      +/-   ##
==========================================
+ Coverage   99.09%   99.16%   +0.07%     
==========================================
  Files         804      802       -2     
  Lines       14187    14150      -37     
  Branches     4017     4008       -9     
==========================================
- Hits        14058    14032      -26     
+ Misses        120      111       -9     
+ Partials        9        7       -2     
Files with missing lines Coverage Δ
.../BundleContent/BundleSelection/BundleSelection.tsx 100.00% <ø> (ø)

... and 14 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <ø> (+0.13%) ⬆️
Services 99.36% <ø> (+<0.01%) ⬆️
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f88d8...3953588. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
3953588 Fri, 08 Nov 2024 19:03:07 GMT Cloud Enterprise

@ajay-sentry ajay-sentry added this pull request to the merge queue Nov 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024
@ajay-sentry ajay-sentry added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit 3b78c9f Nov 15, 2024
61 of 62 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/center-bundle-selectors branch November 15, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants