Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct the deactivated repo message #3482

Merged
merged 2 commits into from
Nov 9, 2024
Merged

fix: Correct the deactivated repo message #3482

merged 2 commits into from
Nov 9, 2024

Conversation

suejung-sentry
Copy link
Contributor

Fix the deactivated repo message to match the correct one here.

Closes codecov/engineering-team#2688

NEW
Screenshot 2024-11-08 at 4 45 52 PM

OLD
Screenshot 2024-11-08 at 4 46 47 PM

@codecov Codecov
Copy link

codecov bot commented Nov 9, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 526 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.54MB 166 bytes (0.0%) ⬆️
gazebo-production-system-esm 5.59MB 360 bytes (0.01%) ⬆️

@codecov-staging
Copy link

codecov-staging bot commented Nov 9, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 526 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.59MB 360 bytes (0.01%) ⬆️
gazebo-staging-system 5.54MB 166 bytes (0.0%) ⬆️

@codecov Codecov
Copy link

codecov bot commented Nov 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.16%. Comparing base (424f106) to head (a87b9bf).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3482   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files         802      802           
  Lines       14150    14150           
  Branches     4015     4015           
=======================================
  Hits        14032    14032           
  Misses        111      111           
  Partials        7        7
Files with missing lines Coverage Δ
...pages/RepoPage/DeactivatedRepo/DeactivatedRepo.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 424f106...a87b9bf. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.16%. Comparing base (424f106) to head (a87b9bf).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3482   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files         802      802           
  Lines       14150    14150           
  Branches     4015     4008    -7     
=======================================
  Hits        14032    14032           
  Misses        111      111           
  Partials        7        7
Files with missing lines Coverage Δ
...pages/RepoPage/DeactivatedRepo/DeactivatedRepo.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 424f106...a87b9bf. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Nov 9, 2024 •
edited by codecov-notifications bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3482   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files         802      802           
  Lines       14150    14150           
  Branches     4008     4015    +7     
=======================================
  Hits        14032    14032           
  Misses        111      111           
  Partials        7        7
Files with missing lines Coverage Δ
...pages/RepoPage/DeactivatedRepo/DeactivatedRepo.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 424f106...a87b9bf. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Nov 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.16%. Comparing base (424f106) to head (a87b9bf).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3482   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files         802      802           
  Lines       14150    14150           
  Branches     4008     4008           
=======================================
  Hits        14032    14032           
  Misses        111      111           
  Partials        7        7
Files Coverage Δ
...pages/RepoPage/DeactivatedRepo/DeactivatedRepo.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 424f106...a87b9bf. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Nov 9, 2024 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
f8b8be3 Sat, 09 Nov 2024 00:53:09 GMT Expired Expired
a87b9bf Sat, 09 Nov 2024 01:00:42 GMT Cloud Enterprise

ajay-sentry
ajay-sentry approved these changes Nov 9, 2024
View reviewed changes
Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ✅ Tried to see if that settings link was something that could be deleted too but couldn't even find a reference to it lol

@suejung-sentry
Copy link
Contributor Author

lgtm ✅ Tried to see if that settings link was something that could be deleted too but couldn't even find a reference to it lol

Thanks for checking! Lol yeah that was part of the problem - the link to the UI spot was just missing before

@suejung-sentry suejung-sentry added this pull request to the merge queue Nov 9, 2024
Merged via the queue into main with commit 9f56184 Nov 9, 2024
62 checks passed
@suejung-sentry suejung-sentry deleted the sshin/fix/2688 branch November 9, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajay-sentry ajay-sentry ajay-sentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[uploads] Upload fails on a deactivated repo before it has the opportunity to auto-activate
3 participants
@suejung-sentry @codecov-releaser @ajay-sentry