fix: TA finishing touches and just in case fixes #3487
Conversation
| } | ||
| }) ?? [] | ||
| ) | ||
| return testData.testResults.map((result) => { |
There was a problem hiding this comment.
huge diff but it's just the removal of ??
| @@ -76,15 +76,20 @@ const BranchSelector = () => { | |||
| ) | |||
| } | |||
|
|
|||
| const sortedBranchList = overview?.defaultBranch | |||
| ? [ | |||
| const sortedBranchList = useMemo(() => { | |||
There was a problem hiding this comment.
adds a check for !branchList?.branches to clean things up a bit
And wraps the whole thing in a useMemo
| flakeRate: z.number(), | ||
| flakeRatePercentChange: z.number().nullable(), | ||
| }) | ||
| .nullable(), |
There was a problem hiding this comment.
nullable just in case
| totalSkips: z.number(), | ||
| totalSkipsPercentChange: z.number().nullable(), | ||
| }) | ||
| .nullable(), |
There was a problem hiding this comment.
nullable just in case
Bundle ReportChanges will increase total bundle size by 418.86kB (2.42%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will increase total bundle size by 418.86kB (2.42%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## tests-analytics-v2 #3487 +/- ##
======================================================
- Coverage 99.09% 99.01% -0.08%
======================================================
Files 810 812 +2
Lines 14422 14457 +35
Branches 4105 4109 +4
======================================================
+ Hits 14291 14315 +24
- Misses 124 133 +9
- Partials 7 9 +2
... and 15 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## tests-analytics-v2 #3487 +/- ##
======================================================
- Coverage 99.09% 99.01% -0.08%
======================================================
Files 810 812 +2
Lines 14422 14457 +35
Branches 4112 4109 -3
======================================================
+ Hits 14291 14315 +24
- Misses 124 133 +9
- Partials 7 9 +2
... and 15 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## tests-analytics-v2 #3487 +/- ##
======================================================
- Coverage 99.09% 99.01% -0.08%
======================================================
Files 810 812 +2
Lines 14422 14457 +35
Branches 4105 4109 +4
======================================================
+ Hits 14291 14315 +24
- Misses 124 133 +9
- Partials 7 9 +2
... and 15 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## tests-analytics-v2 #3487 +/- ##
======================================================
- Coverage 99.09% 99.01% -0.08%
======================================================
Files 810 812 +2
Lines 14422 14457 +35
Branches 4112 4116 +4
======================================================
+ Hits 14291 14315 +24
- Misses 124 133 +9
- Partials 7 9 +2
... and 15 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
This PR does a lot of teeny updates and fixes in preparation for the TA launch:
Screenshots
Screen.Recording.2024-11-12.at.10.05.55.AM.mov
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.