Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide navigator on sync page #3504

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nicholas-codecov
Copy link
Contributor

Description

Quick fix to hide this navigator on the sync page.

Notable Changes

  • Hide navigator in Header while on sync page

Screenshots

Before:

Screenshot 2024-11-15 at 14 24 46

After:

Screenshot 2024-11-15 at 15 13 55

@codecov-staging
Copy link

codecov-staging bot commented Nov 15, 2024

Bundle Report

Changes will decrease total bundle size by 376 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.61MB 324 bytes (-0.01%) ⬇️
gazebo-staging-system 5.56MB 52 bytes (-0.0%) ⬇️

Copy link

codecov bot commented Nov 15, 2024

Bundle Report

Changes will decrease total bundle size by 376 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.56MB 52 bytes (-0.0%) ⬇️
gazebo-production-system-esm 5.61MB 324 bytes (-0.01%) ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.96%. Comparing base (f461fa7) to head (e91387c).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3504      +/-   ##
==========================================
- Coverage   99.09%   98.96%   -0.14%     
==========================================
  Files         805      806       +1     
  Lines       14344    14362      +18     
  Branches     4070     4080      +10     
==========================================
- Hits        14214    14213       -1     
- Misses        123      142      +19     
  Partials        7        7              
Files with missing lines Coverage Δ
src/layouts/Header/Header.tsx 100.00% <100.00%> (ø)

... and 35 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <100.00%> (ø)
Pages 98.60% <ø> (-0.21%) ⬇️
Services 99.36% <ø> (ø)
Shared 99.59% <ø> (-0.14%) ⬇️
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f461fa7...e91387c. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3504      +/-   ##
==========================================
- Coverage   99.09%   98.96%   -0.14%     
==========================================
  Files         805      806       +1     
  Lines       14344    14362      +18     
  Branches     4077     4073       -4     
==========================================
- Hits        14214    14213       -1     
- Misses        123      142      +19     
  Partials        7        7              
Files with missing lines Coverage Δ
src/layouts/Header/Header.tsx 100.00% <100.00%> (ø)

... and 35 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <100.00%> (ø)
Pages 98.60% <ø> (-0.21%) ⬇️
Services 99.36% <ø> (ø)
Shared 99.59% <ø> (-0.14%) ⬇️
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f461fa7...e91387c. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
e91387c Fri, 15 Nov 2024 19:31:03 GMT Cloud Enterprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants