Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Move <h2> outside of <ul> for improved semantic structure #49

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Anjalisharma8072
Copy link

@Anjalisharma8072 Anjalisharma8072 commented Oct 13, 2024

This pull request addresses a structural bug in the HTML code where the h2 heading for "My Feed" was incorrectly placed inside the ul element.

Solution:
Placing heading elements inside a list can lead to confusion regarding the document structure and may affect accessibility for screen readers. By positioning the h2 correctly, I enhance the readability and semantics of the HTML document, ensuring that it accurately reflects the content hierarchy

@sonnynomnom
Copy link
Member

Hi Anjali! This is a great catch. Looks like prettier adjusted the formatting as well.

However, because the code is in the CSS pre-loaded. We'd need to fix that as well. So going to backlog this for now, but going to keep the PR~

@Anjalisharma8072
Copy link
Author

okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants