fix(FCM.Error): handle multiple elements in "details" list with recursive parsing #293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of the
parse/1
function inPigeon.FCM.Error
does not correctly handle cases where the "details" list contains multiple elements. It only matches when only one element is in the list and has an "errorCode", causing certain errors to be mapped as:unknown_error
instead of the expected values.In our production logs, we are seeing a large number of
:unknown_error
entries with the following error message:This should be mapped as
:unregistered
, but the current implementation fails to find the "errorCode" because multiple elements are in the list.Solution
This PR refactors the
parse/1
function to use a recursive approach for parsing the "details" list. It now iterates through all elements until it finds one with an "errorCode" and correctly maps it to the corresponding atom. If no "errorCode" is found, it falls back to checking the "status" field.