Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements Flag for PYSymbol and TSSymbol #284

Merged

Conversation

kopekC
Copy link
Contributor

@kopekC kopekC commented Feb 4, 2025

Motivation

Content

Testing

Please check the following before marking your PR as ready for review

  • [ x] I have added tests for my changes
  • [ x] I have updated the documentation or added new documentation as needed

@kopekC kopekC requested review from codegen-team and a team as code owners February 4, 2025 23:35
@kopekC kopekC requested review from christinewangcw and removed request for a team February 4, 2025 23:35
Copy link
Contributor

@EdwardJXLi EdwardJXLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO ship it

src/codegen/sdk/python/symbol.py Show resolved Hide resolved
src/codegen/sdk/typescript/symbol.py Show resolved Hide resolved
@kopekC kopekC enabled auto-merge (squash) February 4, 2025 23:59
@kopekC kopekC merged commit 73fb210 into develop Feb 5, 2025
26 of 29 checks passed
@kopekC kopekC deleted the pujol-cg-10666-implement-flag-on-pysymbol-and-tssymbol branch February 5, 2025 00:07
jayhack pushed a commit that referenced this pull request Feb 9, 2025
# Motivation

<!-- Why is this change necessary? -->

# Content

<!-- Please include a summary of the change -->

# Testing

<!-- How was the change tested? -->

# Please check the following before marking your PR as ready for review

- [ x] I have added tests for my changes
- [ x] I have updated the documentation or added new documentation as
needed

---------

Co-authored-by: kopekC <[email protected]>
Co-authored-by: codegen-team <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants