Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update for CI 4.5.0 #1090

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 8, 2024

Description

  • update test code
  • update phpstan-baseline.php

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label Apr 8, 2024
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

1) Tests\Unit\AuthRoutesTest::testRoutesCustomNamespace
ErrorException: Undefined array key "register"

P:\MyGitHubWork\shield\tests\Unit\AuthRoutesTest.php:64

--

There were 2 failures:

1) Tests\Unit\AuthRoutesTest::testRoutes
Failed asserting that an array has the key 'register'.

P:\MyGitHubWork\shield\tests\Unit\AuthRoutesTest.php:32

2) Tests\Unit\AuthRoutesTest::testRoutesExcept
Failed asserting that an array has the key 'register'.

P:\MyGitHubWork\shield\tests\Unit\AuthRoutesTest.php:49

For fix get => GET

@kenjis
Copy link
Member Author

kenjis commented Apr 8, 2024

Thank you for the review.
At least, PHPStan errors will be gone.

@kenjis kenjis merged commit af7ddd6 into codeigniter4:develop Apr 8, 2024
20 of 31 checks passed
@kenjis kenjis deleted the update-test-CI45 branch April 8, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Pull requests that changes tests only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants